Commit 79fe249c8368be35c9ca05982e80c68e959505e1
Committed by
Ingo Molnar
1 parent
1eb90f138b
Exists in
master
and in
7 other branches
tracing: Fix failure path in ftrace_regex_open()
Don't forget to free trace_parser if seq_open() returned failure. Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Steven Rostedt <rostedt@goodmis.org> LKML-Reference: <4AB86694.4040803@cn.fujitsu.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Showing 1 changed file with 3 additions and 1 deletions Side-by-side Diff
kernel/trace/ftrace.c
... | ... | @@ -1621,8 +1621,10 @@ |
1621 | 1621 | if (!ret) { |
1622 | 1622 | struct seq_file *m = file->private_data; |
1623 | 1623 | m->private = iter; |
1624 | - } else | |
1624 | + } else { | |
1625 | + trace_parser_put(&iter->parser); | |
1625 | 1626 | kfree(iter); |
1627 | + } | |
1626 | 1628 | } else |
1627 | 1629 | file->private_data = iter; |
1628 | 1630 | mutex_unlock(&ftrace_regex_lock); |