Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 7e7eb4346329da3b9fd4b8d4a5a66d327d9fff6c

Authored by Emil Tantilov
Committed by Jeff Kirsher
1 parent c27931da83
Exists in master and in 7 other branches imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

ixgbe: remove timer reset to 0 on timeout 

The VF mailbox polling for acks and messages would reset the timer to zero
on a timeout. Under heavy load a timeout may actually occur without being
the result of an error and when this occurs it is not practical to perform
a full VF driver reset on every message timeout. Instead, just return an
error (which is already done) and the VF driver will have an opportunity
to retry the operation.

Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Acked-by: Greg Rose <gregory.v.rose@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

Showing 1 changed file with 0 additions and 6 deletions Side-by-side Diff

drivers/net/ixgbe/ixgbe_mbx.c
Diff comments   View file @ 7e7eb43
... ... @@ -154,9 +154,6 @@
154 154 udelay(mbx->usec_delay);
155 155 }
156 156  
157   - /* if we failed, all future posted messages fail until reset */
158   - if (!countdown)
159   - mbx->timeout = 0;
160 157 out:
161 158 return countdown ? 0 : IXGBE_ERR_MBX;
162 159 }
... ... @@ -183,9 +180,6 @@
183 180 udelay(mbx->usec_delay);
184 181 }
185 182  
186   - /* if we failed, all future posted messages fail until reset */
187   - if (!countdown)
188   - mbx->timeout = 0;
189 183 out:
190 184 return countdown ? 0 : IXGBE_ERR_MBX;
191 185 }