Commit 7ec373cf33533af6c50828a62f6b305c2d7fa931
1 parent
116ba5d5ea
Exists in
master
and in
7 other branches
ocfs2: document access rules for blocked_lock_list
ocfs2_super->blocked_lock_list and ocfs2_super->blocked_lock_count have some usage restrictions which aren't immediately obvious to anyone reading the code. It's a good idea to document this so that we avoid making costly mistakes in the future. Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
Showing 1 changed file with 6 additions and 0 deletions Side-by-side Diff
fs/ocfs2/ocfs2.h
| ... | ... | @@ -262,6 +262,12 @@ |
| 262 | 262 | unsigned long dc_wake_sequence; |
| 263 | 263 | unsigned long dc_work_sequence; |
| 264 | 264 | |
| 265 | + /* | |
| 266 | + * Any thread can add locks to the list, but the downconvert | |
| 267 | + * thread is the only one allowed to remove locks. Any change | |
| 268 | + * to this rule requires updating | |
| 269 | + * ocfs2_downconvert_thread_do_work(). | |
| 270 | + */ | |
| 265 | 271 | struct list_head blocked_lock_list; |
| 266 | 272 | unsigned long blocked_lock_count; |
| 267 | 273 |