Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 7ec872114251b618adf5a2688de0ca00de63635d

Authored by Florian Fainelli
Committed by David S. Miller
1 parent 1010dcceed
Exists in smarc-imx_3.14.28_1.0.0_ga and in 1 other branch imx_3.14.28_1.0.0_ga

net: ethtool: disambiguate XCVR_* meaning 

Add a comment which explains the real meaning of XCVR_INTERNAL (PHY and
Ethernet MAC in the same package/die) and XCVR_EXTERNAL (PHY and
Ethernet MAC in a different package/die). Most if not all of the drivers
setting their transceiver type already do it the way the comment
describes it.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 1 changed file with 2 additions and 2 deletions Side-by-side Diff

include/uapi/linux/ethtool.h
Diff comments   View file @ 7ec8721
... ... @@ -993,8 +993,8 @@
993 993 #define PORT_OTHER 0xff
994 994  
995 995 /* Which transceiver to use. */
996   -#define XCVR_INTERNAL 0x00
997   -#define XCVR_EXTERNAL 0x01
  996 +#define XCVR_INTERNAL 0x00 /* PHY and MAC are in the same package */
  997 +#define XCVR_EXTERNAL 0x01 /* PHY and MAC are in different packages */
998 998 #define XCVR_DUMMY1 0x02
999 999 #define XCVR_DUMMY2 0x03
1000 1000 #define XCVR_DUMMY3 0x04