Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 84c4a9dfbf430861e7588d95ae3ff61535dca351

Authored by Cong Wang
Committed by David S. Miller
1 parent 5dbd506843
Exists in smarc-l5.0.0_1.0.0-ga and in 5 other branches imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga

xfrm6: release dev before returning error 

We forget to call dev_put() on error path in xfrm6_fill_dst(),
its caller doesn't handle this.

Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Cong Wang <amwang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 1 changed file with 3 additions and 1 deletions Side-by-side Diff

net/ipv6/xfrm6_policy.c
Diff comments   View file @ 84c4a9d
... ... @@ -103,8 +103,10 @@
103 103 dev_hold(dev);
104 104  
105 105 xdst->u.rt6.rt6i_idev = in6_dev_get(dev);
106   - if (!xdst->u.rt6.rt6i_idev)
  106 + if (!xdst->u.rt6.rt6i_idev) {
  107 + dev_put(dev);
107 108 return -ENODEV;
  109 + }
108 110  
109 111 rt6_transfer_peer(&xdst->u.rt6, rt);
110 112