Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 8524b001a21747c7df5c5a8404f0fbf45661ea44

Authored by Thomas Meyer
Committed by David S. Miller
1 parent efd0bf97de
Exists in master and in 6 other branches imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

irttp: Use kmemdup rather than duplicating its implementation 

The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 1 changed file with 1 additions and 3 deletions Side-by-side Diff

... ... @@ -1461,14 +1461,12 @@
1461 1461 }
1462 1462  
1463 1463 /* Allocate a new instance */
1464   - new = kmalloc(sizeof(struct tsap_cb), GFP_ATOMIC);
  1464 + new = kmemdup(orig, sizeof(struct tsap_cb), GFP_ATOMIC);
1465 1465 if (!new) {
1466 1466 IRDA_DEBUG(0, "%s(), unable to kmalloc\n", __func__);
1467 1467 spin_unlock_irqrestore(&irttp->tsaps->hb_spinlock, flags);
1468 1468 return NULL;
1469 1469 }
1470   - /* Dup */
1471   - memcpy(new, orig, sizeof(struct tsap_cb));
1472 1470 spin_lock_init(&new->lock);
1473 1471  
1474 1472 /* We don't need the old instance any more */