Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 87575437d8173c7da48a4dee25399807c7bec9cb

Authored by Julia Lawall
Committed by Linus Torvalds
1 parent 56d611a04f
Exists in master and in 7 other branches imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

drivers/char/ppdev.c: use kasprintf 

kasprintf combines kmalloc and sprintf, and takes care of the size
calculation itself.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression a,flag;
expression list args;
statement S;
@@

  a =
-  \(kmalloc\|kzalloc\)(...,flag)
+  kasprintf(flag,args)
  <... when != a
  if (a == NULL || ...) S
  ...>
- sprintf(a,args);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 1 additions and 3 deletions Side-by-side Diff

drivers/char/ppdev.c
Diff comments   View file @ 8757543
... ... @@ -287,11 +287,9 @@
287 287 char *name;
288 288 int fl;
289 289  
290   - name = kmalloc (strlen (CHRDEV) + 3, GFP_KERNEL);
  290 + name = kasprintf(GFP_KERNEL, CHRDEV "%x", minor);
291 291 if (name == NULL)
292 292 return -ENOMEM;
293   -
294   - sprintf (name, CHRDEV "%x", minor);
295 293  
296 294 port = parport_find_number (minor);
297 295 if (!port) {