Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 91e260b80d2fec559877f399dfc36b554f207874

Authored by Jim Cromie
Committed by Linus Torvalds
1 parent b9432e4d88
Exists in master and in 7 other branches imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

[PATCH] gpio: drop vtable members .gpio_set_high .gpio_set_low gpio_set is enough 

drops gpio_set_high, gpio_set_low from the nsc_gpio_ops vtable.  While we
can't drop them from scx200_gpio (or can we?), we dont need them for new users
of the exported vtable; gpio_set(1), gpio_set(0) work fine.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

Showing 3 changed files with 0 additions and 6 deletions Side-by-side Diff

drivers/char/pc8736x_gpio.c
Diff comments   View file @ 91e260b
... ... @@ -218,8 +218,6 @@
218 218 .gpio_dump = nsc_gpio_dump,
219 219 .gpio_get = pc8736x_gpio_get,
220 220 .gpio_set = pc8736x_gpio_set,
221   - .gpio_set_high = pc8736x_gpio_set_high,
222   - .gpio_set_low = pc8736x_gpio_set_low,
223 221 .gpio_change = pc8736x_gpio_change,
224 222 .gpio_current = pc8736x_gpio_current
225 223 };
drivers/char/scx200_gpio.c
Diff comments   View file @ 91e260b
... ... @@ -41,8 +41,6 @@
41 41 .gpio_dump = nsc_gpio_dump,
42 42 .gpio_get = scx200_gpio_get,
43 43 .gpio_set = scx200_gpio_set,
44   - .gpio_set_high = scx200_gpio_set_high,
45   - .gpio_set_low = scx200_gpio_set_low,
46 44 .gpio_change = scx200_gpio_change,
47 45 .gpio_current = scx200_gpio_current
48 46 };
include/linux/nsc_gpio.h
Diff comments   View file @ 91e260b
... ... @@ -25,8 +25,6 @@
25 25 void (*gpio_dump) (struct nsc_gpio_ops *amp, unsigned iminor);
26 26 int (*gpio_get) (unsigned iminor);
27 27 void (*gpio_set) (unsigned iminor, int state);
28   - void (*gpio_set_high)(unsigned iminor);
29   - void (*gpio_set_low) (unsigned iminor);
30 28 void (*gpio_change) (unsigned iminor);
31 29 int (*gpio_current) (unsigned iminor);
32 30 struct device* dev; /* for dev_dbg() support, set in init */