Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 95cc7baa7f19e191b4790d144b7cbe47369cfe32

Authored by Julia Lawall
Committed by Linus Torvalds
1 parent 085267acd0
Exists in master and in 7 other branches imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

drivers/scsi: remove unnecessary NULL test 

At the point where cmnd is initialized, it is tested for NULL, so it
doesn't have to be tested again here.

A simplified version of the semantic match that detects this problem is as
follows (http://coccinelle.lip6.fr/):

// <smpl>
@match exists@
expression x, E;
identifier fld;
@@

* x->fld
  ... when != \(x = E\|&x\)
* x == NULL
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 0 additions and 1 deletions Side-by-side Diff

drivers/scsi/initio.c
Diff comments   View file @ 95cc7ba
... ... @@ -2817,7 +2817,6 @@
2817 2817 }
2818 2818  
2819 2819 cmnd->result = cblk->tastat | (cblk->hastat << 16);
2820   - WARN_ON(cmnd == NULL);
2821 2820 i91u_unmap_scb(host->pci_dev, cmnd);
2822 2821 cmnd->scsi_done(cmnd); /* Notify system DONE */
2823 2822 initio_release_scb(host, cblk); /* Release SCB for current channel */