Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 962f3ffa927f2e777a4193843c45ffa6e52ff4b6

Authored by Akinobu Mita
Committed by Greg Kroah-Hartman
1 parent 60b0bf0f11
Exists in master and in 7 other branches imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

wusb: fix find_first_zero_bit() return value check 

In wusb_cluster_id_get(), if no zero bits exist in wusb_cluster_id_table,
find_first_zero_bit() returns CLUSTER_IDS.

But it is impossible to detect that the bitmap is full because there
is an off-by-one error in the return value check.  It will cause
unexpected memory access by setting bit out of wusb_cluster_id_table
bitmap, and caller will get wrong cluster id.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-usb@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

drivers/usb/wusbcore/wusbhc.c
Diff comments   View file @ 962f3ff
... ... @@ -320,7 +320,7 @@
320 320 u8 id;
321 321 spin_lock(&wusb_cluster_ids_lock);
322 322 id = find_first_zero_bit(wusb_cluster_id_table, CLUSTER_IDS);
323   - if (id > CLUSTER_IDS) {
  323 + if (id >= CLUSTER_IDS) {
324 324 id = 0;
325 325 goto out;
326 326 }