[MYRI_SBUS]: Prevent that myri_do_handshake lies about ticks.

With '<=' tick can be incremented up to 26, The last loop is redundant since even when 'softstate' becomes 'STATE_READY', 'if (tick > 25)' will still cause the function to return -1, Signed-off-by: Roel Kluin <12o3l@tiscali.nl> Signed-off-by: David S. Miller <davem@davemloft.net>

[MYRI_SBUS]: Prevent that myri_do_handshake lies about ticks.
With '<=' tick can be incremented up to 26, The last loop is redundant since even when 'softstate' becomes 'STATE_READY', 'if (tick > 25)' will still cause the function to return -1, Signed-off-by: Roel Kluin <12o3l@tiscali.nl> Signed-off-by: David S. Miller <davem@davemloft.net>
Roel Kluin · David S. Miller
1 parent 81d9ddae85
Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff
drivers/net/myri_sbus.c
@@ -134,7 +134,7 @@
  
 	myri_disable_irq(mp->lregs, cregs);
  
-	while (tick++ <= 25) {
+	while (tick++ < 25) {
 		u32 softstate;
  
 		/* Wake it up. */
...	...	@@ -134,7 +134,7 @@
134	134
135	135	myri_disable_irq(mp->lregs, cregs);
136	136
137		- while (tick++ <= 25) {
	137	+ while (tick++ < 25) {
138	138	u32 softstate;
139	139
140	140	/* Wake it up. */