Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit 9fcc2e8a752f7d3d889114221b67c459557823e9

Authored by Jayachandran C
Committed by Arnaldo Carvalho de Melo
1 parent 360ac8e2f1
Exists in master and in 7 other branches imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

[IPV4]: Fix issue reported by Coverity in ipv4/fib_frontend.c 

fib_del_ifaddr() dereferences ifa->ifa_dev, so the code already assumes that
ifa->ifa_dev is non-NULL, the check is unnecessary.

Signed-off-by: Jayachandran C. <c.jayachandran at gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

net/ipv4/fib_frontend.c
Diff comments   View file @ 9fcc2e8
... ... @@ -591,7 +591,7 @@
591 591 break;
592 592 case NETDEV_DOWN:
593 593 fib_del_ifaddr(ifa);
594   - if (ifa->ifa_dev && ifa->ifa_dev->ifa_list == NULL) {
  594 + if (ifa->ifa_dev->ifa_list == NULL) {
595 595 /* Last address was deleted from this interface.
596 596 Disable IP.
597 597 */