Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit a4be637b34a543af5b5421a8ee0ee04d30f5f58e

Authored by Roy.Li
Committed by Ralf Baechle
1 parent 2f19d080fb
Exists in master and in 6 other branches imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

staging/octeon: Software should check the checksum of no tcp/udp packets 

Icmp packets with wrong checksum are never dropped since skb->ip_summed is
set to CHECKSUM_UNNECESSARY.

When icmp packets with wrong checksum pass through the octeon net driver,
the not_IP, IP_exc, L4_error hardware indicators show no error. so the
driver sets CHECKSUM_UNNECESSARY on skb->ip_summed.

L4_error only works for TCP/UDP, not for ICMP.

Signed-off-by: Roy.Li <rongqing.li@windriver.com>
To: linux-mips@linux-mips.org
Cc: netdev@vger.kernel.org
Cc: ralf@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/2798/
Acked-by: David Daney <david.daney@cavium.com>
Cc: Greg KH <greg@kroah.com
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

Showing 1 changed file with 2 additions and 1 deletions Side-by-side Diff

drivers/staging/octeon/ethernet-rx.c
Diff comments   View file @ a4be637
... ... @@ -411,7 +411,8 @@
411 411 skb->protocol = eth_type_trans(skb, dev);
412 412 skb->dev = dev;
413 413  
414   - if (unlikely(work->word2.s.not_IP || work->word2.s.IP_exc || work->word2.s.L4_error))
  414 + if (unlikely(work->word2.s.not_IP || work->word2.s.IP_exc ||
  415 + work->word2.s.L4_error || !work->word2.s.tcp_or_udp))
415 416 skb->ip_summed = CHECKSUM_NONE;
416 417 else
417 418 skb->ip_summed = CHECKSUM_UNNECESSARY;