Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit a4bf06d58f219230ee38e338fdda225973d44aa1

Authored by Dan Carpenter
Committed by Guenter Roeck
1 parent 60c1f31fc5
Exists in smarc-imx_3.14.28_1.0.0_ga and in 1 other branch imx_3.14.28_1.0.0_ga

hwmon: (adt7462) ADT7462_REG_VOLT_MAX() should return 0 

The callers never check for negative but they sometimes check for zero
returns:

	int reg = ADT7462_REG_VOLT_MAX(data, i);
        data->volt_max[i] =
		(reg ? i2c_smbus_read_byte_data(client, reg) : 0);

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Showing 1 changed file with 2 additions and 2 deletions Side-by-side Diff

drivers/hwmon/adt7462.c
Diff comments   View file @ a4bf06d
... ... @@ -333,7 +333,7 @@
333 333 return 0x4C;
334 334 break;
335 335 }
336   - return -ENODEV;
  336 + return 0;
337 337 }
338 338  
339 339 static int ADT7462_REG_VOLT_MIN(struct adt7462_data *data, int which)
... ... @@ -392,7 +392,7 @@
392 392 return 0x77;
393 393 break;
394 394 }
395   - return -ENODEV;
  395 + return 0;
396 396 }
397 397  
398 398 static int ADT7462_REG_VOLT(struct adt7462_data *data, int which)