Commit af1c51fcb2aea23ec2dfe73b7d66515d1622e689

Authored by Marcelo Tosatti
Committed by Greg Kroah-Hartman
1 parent 0eb0226c9d

USB: EHCI restart speedup

It is not necessary to powerdown the ports on ehci_pci_reinit() when the
chip reset already did that.  Removing this saves 20ms during restart
after poweroff paths (which OLPC uses a lot).

To ensure driver startup then behaves consistently, force a reset during
driver startup.  (Not doing this was an accident of some previous changes
to the init sequence.)

Make the corresponding change in the PS3 support.  It's not clear what
ehci-fsl should do here; it has similar code to the PS3.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Cc: <rvinson@mvista.com>
Acked-by: Geoff Levand <geoffrey.levand@am.sony.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

Showing 2 changed files with 2 additions and 5 deletions Side-by-side Diff

drivers/usb/host/ehci-pci.c
... ... @@ -58,8 +58,6 @@
58 58 if (!retval)
59 59 ehci_dbg(ehci, "MWI active\n");
60 60  
61   - ehci_port_power(ehci, 0);
62   -
63 61 return 0;
64 62 }
65 63  
... ... @@ -156,8 +154,7 @@
156 154 break;
157 155 }
158 156  
159   - if (ehci_is_TDI(ehci))
160   - ehci_reset(ehci);
  157 + ehci_reset(ehci);
161 158  
162 159 /* at least the Genesys GL880S needs fixup here */
163 160 temp = HCS_N_CC(ehci->hcs_params) * HCS_N_PCC(ehci->hcs_params);
drivers/usb/host/ehci-ps3.c
... ... @@ -47,7 +47,7 @@
47 47 if (result)
48 48 return result;
49 49  
50   - ehci_port_power(ehci, 0);
  50 + ehci_reset(ehci);
51 51  
52 52 return result;
53 53 }