ext4: don't set i_flags in EXT4_IOC_SETFLAGS

Commit 7990696 uses the ext4_{set,clear}_inode_flags() functions to change the i_flags automatically but fails to remove the error setting of i_flags. So we still have the problem of trashing state flags. Fix this by removing the assignment. Signed-off-by: Tao Ma <boyu.mt@taobao.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> Cc: stable@kernel.org

ext4: don't set i_flags in EXT4_IOC_SETFLAGS
Commit 7990696 uses the ext4_{set,clear}_inode_flags() functions to change the i_flags automatically but fails to remove the error setting of i_flags. So we still have the problem of trashing state flags. Fix this by removing the assignment. Signed-off-by: Tao Ma <boyu.mt@taobao.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> Cc: stable@kernel.org
Tao Ma · Theodore Ts'o
1 parent b0dd6b70f0
Showing 1 changed file with 0 additions and 1 deletions Side-by-side Diff
fs/ext4/ioctl.c
@@ -123,7 +123,6 @@
 			else
 				ext4_clear_inode_flag(inode, i);
 		}
-		ei->i_flags = flags;
  
 		ext4_set_inode_flags(inode);
 		inode->i_ctime = ext4_current_time(inode);
...	...	@@ -123,7 +123,6 @@
123	123	else
124	124	ext4_clear_inode_flag(inode, i);
125	125	}
126		- ei->i_flags = flags;
127	126
128	127	ext4_set_inode_flags(inode);
129	128	inode->i_ctime = ext4_current_time(inode);