Commit b379135c40163ae79ba7a54e6928b53983e74ee8
Committed by
David S. Miller
1 parent
85e87870fa
Exists in
smarc-l5.0.0_1.0.0-ga
and in
5 other branches
fq_codel: dont reinit flow state
When fq_codel builds a new flow, it should not reset codel state. Codel algo needs to get previous values (lastcount, drop_next) to get proper behavior. Signed-off-by: Dave Taht <dave.taht@gmail.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Acked-by: Dave Taht <dave.taht@bufferbloat.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff
net/sched/sch_fq_codel.c
... | ... | @@ -191,7 +191,6 @@ |
191 | 191 | |
192 | 192 | if (list_empty(&flow->flowchain)) { |
193 | 193 | list_add_tail(&flow->flowchain, &q->new_flows); |
194 | - codel_vars_init(&flow->cvars); | |
195 | 194 | q->new_flow_count++; |
196 | 195 | flow->deficit = q->quantum; |
197 | 196 | flow->dropped = 0; |
... | ... | @@ -418,6 +417,7 @@ |
418 | 417 | struct fq_codel_flow *flow = q->flows + i; |
419 | 418 | |
420 | 419 | INIT_LIST_HEAD(&flow->flowchain); |
420 | + codel_vars_init(&flow->cvars); | |
421 | 421 | } |
422 | 422 | } |
423 | 423 | if (sch->limit >= 1) |