Commit b6a71bfa00eb110c8a2e38f85572ed361f8bf3a5

Authored by Ben Dooks
Committed by David S. Miller
1 parent 160d0fadaf

KS8851: Fix ks8851_set_rx_mode() for IFF_MULTICAST

In ks8851_set_rx_mode() the case handling IFF_MULTICAST was also setting
the RXCR1_AE bit by accident. This meant that all unicast frames where
being accepted by the device. Remove RXCR1_AE from this case.

Note, RXCR1_AE was also masking a problem with setting the MAC address
properly, so needs to be applied after fixing the MAC write order.

Fixes a bug reported by Doong, Ping of Micrel. This version of the
patch avoids setting RXCR1_ME for all cases.

Signed-off-by: Ben Dooks <ben@simtec.co.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

drivers/net/ks8851.c
... ... @@ -980,7 +980,7 @@
980 980 mcptr = mcptr->next;
981 981 }
982 982  
983   - rxctrl.rxcr1 = RXCR1_RXME | RXCR1_RXAE | RXCR1_RXPAFMA;
  983 + rxctrl.rxcr1 = RXCR1_RXME | RXCR1_RXPAFMA;
984 984 } else {
985 985 /* just accept broadcast / unicast */
986 986 rxctrl.rxcr1 = RXCR1_RXPAFMA;