Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit b7165ebbf0898bad9aaeddfa22b918e94ed90e07

Authored by Kees Cook
Committed by Greg Kroah-Hartman
1 parent fc60bb8339
Exists in smarc-imx_3.14.28_1.0.0_ga and in 1 other branch imx_3.14.28_1.0.0_ga

kobject: sanitize argument for format string 

Unlike kobject_set_name(), the kset_create_and_add() interface does not
provide a way to use format strings, so make sure that the interface
cannot be abused accidentally. It looks like all current callers use
static strings, so there's no existing flaw.

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

... ... @@ -805,7 +805,7 @@
805 805 kset = kzalloc(sizeof(*kset), GFP_KERNEL);
806 806 if (!kset)
807 807 return NULL;
808   - retval = kobject_set_name(&kset->kobj, name);
  808 + retval = kobject_set_name(&kset->kobj, "%s", name);
809 809 if (retval) {
810 810 kfree(kset);
811 811 return NULL;