Commit bfeeeeb991cf75081e6c2f74d44ae5da05b50a94

Authored by Johannes Berg
Committed by Thomas Gleixner
1 parent 75d3bce2fc

stacktrace: don't crash on invalid stack trace structs

This patch makes the stacktrace printout code \warn when the entries
pointer is unset rather than crashing when trying to access it in an
attempt to make it a bit more robust.

I was saving a stacktrace into an skb and forgot to copy it across skb
copies... I have since fixed the code, but it would have been easier
had the kernel not crashed in an interrupt.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Showing 1 changed file with 3 additions and 0 deletions Side-by-side Diff

... ... @@ -13,6 +13,9 @@
13 13 {
14 14 int i, j;
15 15  
  16 + if (WARN_ON(!trace->entries))
  17 + return;
  18 +
16 19 for (i = 0; i < trace->nr_entries; i++) {
17 20 unsigned long ip = trace->entries[i];
18 21