Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit c130480b129fbfd7932ad7af3f4ffcea630b027f

Authored by Nicholas Bellinger
1 parent 28aaa95032
Exists in smarc-imx_3.14.28_1.0.0_ga and in 1 other branch imx_3.14.28_1.0.0_ga

target: Fix se_cmd->state_list leak regression during WRITE failure 

This patch addresses a v3.11 specific regression where se_cmd->state_list
was being leaked during a fabric WRITE failure, when the fabric releases
an associated se_cmd descriptor before I/O submission occurs, and normal
fast path callbacks have a chance to call target_remove_from_state_list().

It was manifesting with Poison overwritten messages with iscsi-target
once an ImmediateData payload CRC32C failure occured.

This bug was originally introduced during v3.11-rc1 with the following
commit:

commit 0b66818ac6de67a6125ae203272fb76e79b3a20f
Author: Nicholas Bellinger <nab@linux-iscsi.org>
Date:   Thu Jun 6 01:36:41 2013 -0700

    target: Drop unnecessary CMD_T_DEV_ACTIVE check from transport_lun_remove_cmd

Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

Showing 1 changed file with 11 additions and 0 deletions Side-by-side Diff

drivers/target/target_core_transport.c
Diff comments   View file @ c130480
... ... @@ -2134,6 +2134,7 @@
2134 2134  
2135 2135 int transport_generic_free_cmd(struct se_cmd *cmd, int wait_for_tasks)
2136 2136 {
  2137 + unsigned long flags;
2137 2138 int ret = 0;
2138 2139  
2139 2140 if (!(cmd->se_cmd_flags & SCF_SE_LUN_CMD)) {
... ... @@ -2144,6 +2145,16 @@
2144 2145 } else {
2145 2146 if (wait_for_tasks)
2146 2147 transport_wait_for_tasks(cmd);
  2148 + /*
  2149 + * Handle WRITE failure case where transport_generic_new_cmd()
  2150 + * has already added se_cmd to state_list, but fabric has
  2151 + * failed command before I/O submission.
  2152 + */
  2153 + if (cmd->state_active) {
  2154 + spin_lock_irqsave(&cmd->t_state_lock, flags);
  2155 + target_remove_from_state_list(cmd);
  2156 + spin_unlock_irqrestore(&cmd->t_state_lock, flags);
  2157 + }
2147 2158  
2148 2159 if (cmd->se_lun)
2149 2160 transport_lun_remove_cmd(cmd);