Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit c5dc3b98fffaf183bb3d5bf690bfab9f6705c5e1

Authored by Antti Palosaari
Committed by Mauro Carvalho Chehab
1 parent 4562620159
Exists in smarc-l5.0.0_1.0.0-ga and in 5 other branches imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga

[media] fc0012: remove unused callback and correct one comment 

There is no need to keep dummy sleep() callback implementation as
DVB-core checks existence of it before calls callback. Due to that
we can remove it.
FC0012 is based of direct-conversion receiver architecture
(aka Zero-IF) where is no IF used. Due to that IF is always 0 Hz.
Fix comment to point that.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Acked-by: Hans-Frieder Vogt <hfvogt@gmx.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

Showing 1 changed file with 1 additions and 9 deletions Side-by-side Diff

drivers/media/tuners/fc0012.c
Diff comments   View file @ c5dc3b9
... ... @@ -129,12 +129,6 @@
129 129 return ret;
130 130 }
131 131  
132   -static int fc0012_sleep(struct dvb_frontend *fe)
133   -{
134   - /* nothing to do here */
135   - return 0;
136   -}
137   -
138 132 static int fc0012_set_params(struct dvb_frontend *fe)
139 133 {
140 134 struct fc0012_priv *priv = fe->tuner_priv;
... ... @@ -343,8 +337,7 @@
343 337  
344 338 static int fc0012_get_if_frequency(struct dvb_frontend *fe, u32 *frequency)
345 339 {
346   - /* CHECK: always ? */
347   - *frequency = 0;
  340 + *frequency = 0; /* Zero-IF */
348 341 return 0;
349 342 }
350 343  
... ... @@ -437,7 +430,6 @@
437 430 .release = fc0012_release,
438 431  
439 432 .init = fc0012_init,
440   - .sleep = fc0012_sleep,
441 433  
442 434 .set_params = fc0012_set_params,
443 435