Commit c5e0cb3ddc5f14cedcfc50c0fb3b5fc6b56576da
Committed by
Ingo Molnar
1 parent
2c28e2451d
Exists in
master
and in
7 other branches
rcu: Cleanup: balance rcu_irq_enter()/rcu_irq_exit() calls
Currently, rcu_irq_exit() is invoked only for CONFIG_NO_HZ, while rcu_irq_enter() is invoked unconditionally. This patch moves rcu_irq_exit() out from under CONFIG_NO_HZ so that the calls are balanced. This patch has no effect on the behavior of the kernel because both rcu_irq_enter() and rcu_irq_exit() are empty for !CONFIG_NO_HZ, but the code is easier to understand if the calls are obviously balanced in all cases. Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Cc: dipankar@in.ibm.com Cc: mathieu.desnoyers@polymtl.ca Cc: josh@joshtriplett.org Cc: dvhltc@us.ibm.com Cc: niv@us.ibm.com Cc: peterz@infradead.org Cc: rostedt@goodmis.org Cc: Valdis.Kletnieks@vt.edu Cc: dhowells@redhat.com LKML-Reference: <12567428891605-git-send-email-> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff
kernel/softirq.c
... | ... | @@ -302,9 +302,9 @@ |
302 | 302 | if (!in_interrupt() && local_softirq_pending()) |
303 | 303 | invoke_softirq(); |
304 | 304 | |
305 | + rcu_irq_exit(); | |
305 | 306 | #ifdef CONFIG_NO_HZ |
306 | 307 | /* Make sure that timer wheel updates are propagated */ |
307 | - rcu_irq_exit(); | |
308 | 308 | if (idle_cpu(smp_processor_id()) && !in_interrupt() && !need_resched()) |
309 | 309 | tick_nohz_stop_sched_tick(0); |
310 | 310 | #endif |