Commit c656fce141afb8db4e7dc5a3af1e82308202698a

Authored by Fabio Estevam
Committed by Greg Kroah-Hartman
1 parent 197d67f122

include/linux/crash_dump.h needs elf.h

commit 1f536b9e9f85456df93614b3c2f6a1a2b7d7cb9b upstream.

Building an ARM target we get the following warnings:

  CC      arch/arm/kernel/setup.o
  In file included from arch/arm/kernel/setup.c:39:
  arch/arm/include/asm/elf.h:102:1: warning: "vmcore_elf64_check_arch" redefined
  In file included from arch/arm/kernel/setup.c:24:
  include/linux/crash_dump.h:30:1: warning: this is the location of the previous definition

Quoting Russell King:

"linux/crash_dump.h makes no attempt to include asm/elf.h, but it depends
on stuff in asm/elf.h to determine how stuff inside this file is defined
at parse time.

So, if asm/elf.h is included after linux/crash_dump.h or not at all, you
get a different result from the situation where asm/elf.h is included
before."

So add elf.h header to crash_dump.h to avoid this problem.

The original discussion about this can be found at:
http://www.spinics.net/lists/arm-kernel/msg154113.html

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

Showing 1 changed file with 1 additions and 0 deletions Side-by-side Diff

include/linux/crash_dump.h
... ... @@ -5,6 +5,7 @@
5 5 #include <linux/kexec.h>
6 6 #include <linux/device.h>
7 7 #include <linux/proc_fs.h>
  8 +#include <linux/elf.h>
8 9  
9 10 #define ELFCORE_ADDR_MAX (-1ULL)
10 11 #define ELFCORE_ADDR_ERR (-2ULL)