Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit c84598bbfa756b7d042da31aa4e198ae866a6c7d

Authored by Shaohua Li
Committed by Linus Torvalds
1 parent 3c8f370ded
Exists in master and in 7 other branches imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

percpu_counter: change return value and add comments 

The percpu_counter_*_positive() API in UP case doesn't check if return
value is positive.  Add comments to explain why we don't.  Also if count <
0, returns 0 instead of 1 for *read_positive().

[akpm@linux-foundation.org: tweak comment]
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 5 additions and 1 deletions Side-by-side Diff

include/linux/percpu_counter.h
Diff comments   View file @ c84598b
... ... @@ -75,7 +75,7 @@
75 75 barrier(); /* Prevent reloads of fbc->count */
76 76 if (ret >= 0)
77 77 return ret;
78   - return 1;
  78 + return 0;
79 79 }
80 80  
81 81 static inline int percpu_counter_initialized(struct percpu_counter *fbc)
... ... @@ -133,6 +133,10 @@
133 133 return fbc->count;
134 134 }
135 135  
  136 +/*
  137 + * percpu_counter is intended to track positive numbers. In the UP case the
  138 + * number should never be negative.
  139 + */
136 140 static inline s64 percpu_counter_read_positive(struct percpu_counter *fbc)
137 141 {
138 142 return fbc->count;