Doug / smarc-fsl-linux-kernel

Download as
Browse Code »

Commit cf5a189d4a02efb3712cfb424452f4ce3ab7c4a2

Authored by hiromu
Committed by Steven Rostedt
1 parent ccece60ac6
Exists in master and in 7 other branches imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

kconfig: Fix missing declaration of variable $dir in streamline_config.pl 

On Fri, Aug 17, 2010 at 01:43PM +0800, Américo Wang wrote:
> Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
>
> BTW, I think we should add "use strict;" too.

Then I added "use strict;" to streamline_config.pl, I saw another
warning.

> Global symbol "$dir" requires explicit package name at
scripts/kconfig/streamline_config.pl line 286.
> Global symbol "$dir" requires explicit package name at
scripts/kconfig/streamline_config.pl line 287.
> Global symbol "$dir" requires explicit package name at
scripts/kconfig/streamline_config.pl line 288.

Then I added "my $dir;" to line 285.

Cc: Américo Wang <xiyou.wangcong@gmail.com>
Cc: Toralf Foerster <toralf.foerster@gmx.de>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: Hiromu Yakura <hiromu1996@gmail.com>
LKML-Reference: <1282042158.7160.9.camel@hiromu-Macbook>

[ changed to just add my in front of $dir instead of new line ]

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

Showing 1 changed file with 3 additions and 1 deletions Side-by-side Diff

scripts/kconfig/streamline_config.pl
Diff comments   View file @ cf5a189
... ... @@ -42,6 +42,8 @@
42 42 # mv config_strip .config
43 43 # make oldconfig
44 44 #
  45 +use strict;
  46 +
45 47 my $config = ".config";
46 48  
47 49 my $uname = `uname -r`;
... ... @@ -291,7 +293,7 @@
291 293 # see what modules are loaded on this system
292 294 my $lsmod;
293 295  
294   - foreach $dir ( ("/sbin", "/bin", "/usr/sbin", "/usr/bin") ) {
  296 + foreach my $dir ( ("/sbin", "/bin", "/usr/sbin", "/usr/bin") ) {
295 297 if ( -x "$dir/lsmod" ) {
296 298 $lsmod = "$dir/lsmod";
297 299 last;