Commit d015baebba44613ef59ddffeae2114fa4ede7104

Authored by Oleg Nesterov
Committed by Linus Torvalds
1 parent 533475d3d4

[PATCH] futex_find_get_task(): remove an obscure EXIT_ZOMBIE check

futex_find_get_task:

	if (p->state == EXIT_ZOMBIE || p->exit_state == EXIT_ZOMBIE)
		return NULL;

I can't understand this.  First, p->state can't be EXIT_ZOMBIE.  The
->exit_state check looks strange too.  Sub-threads or tasks whose ->parent
ignores SIGCHLD go directly to EXIT_DEAD state (I am ignoring a ptrace
case).  Why EXIT_DEAD tasks should be ok?  Yes, EXIT_ZOMBIE is more
important (a task may stay zombie for a long time), but this doesn't mean
we should explicitely ignore other EXIT_XXX states.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

... ... @@ -397,7 +397,7 @@
397 397 p = NULL;
398 398 goto out_unlock;
399 399 }
400   - if (p->state == EXIT_ZOMBIE || p->exit_state == EXIT_ZOMBIE) {
  400 + if (p->exit_state != 0) {
401 401 p = NULL;
402 402 goto out_unlock;
403 403 }