hold task_lock around checks in keyctl

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

hold task_lock around checks in keyctl
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Al Viro
1 parent 6120d3dbb1
Showing 1 changed file with 2 additions and 0 deletions Side-by-side Diff
security/keys/keyctl.c
@@ -1486,6 +1486,7 @@
 	oldwork = NULL;
 	parent = me->real_parent;
  
+	task_lock(parent);
 	/* the parent mustn't be init and mustn't be a kernel thread */
 	if (parent->pid <= 1 || !parent->mm)
 		goto unlock;
@@ -1529,6 +1530,7 @@
 	if (!ret)
 		newwork = NULL;
 unlock:
+	task_unlock(parent);
 	write_unlock_irq(&tasklist_lock);
 	rcu_read_unlock();
 	if (oldwork)
...	...	@@ -1486,6 +1486,7 @@
1486	1486	oldwork = NULL;
1487	1487	parent = me->real_parent;
1488	1488
	1489	+ task_lock(parent);
1489	1490	/* the parent mustn't be init and mustn't be a kernel thread */
1490	1491	if (parent->pid <= 1 \|\| !parent->mm)
1491	1492	goto unlock;
...	...	@@ -1529,6 +1530,7 @@
1529	1530	if (!ret)
1530	1531	newwork = NULL;
1531	1532	unlock:
	1533	+ task_unlock(parent);
1532	1534	write_unlock_irq(&tasklist_lock);
1533	1535	rcu_read_unlock();
1534	1536	if (oldwork)