Commit db71daabad0821996483dfe309c4bc81d6755a70
Committed by
Linus Torvalds
1 parent
74588d8ba3
Exists in
master
and in
7 other branches
[PATCH] Generic ioremap_page_range: flush_cache_vmap
The existing implementation of ioremap_page_range(), which was taken from i386, does this: flush_cache_all(); /* modify page tables */ flush_tlb_all(); I think this is a bit defensive, so this patch changes the generic implementation to do: /* modify page tables */ flush_cache_vmap(start, end); instead, which is similar to what vmalloc() does. This should still be correct because we never modify existing PTEs. According to James Bottomley: The problem the flush_tlb_all() is trying to solve is to avoid stale tlb entries in the ioremap area. We're just being conservative by flushing on both map and unmap. Technically what vmalloc/vfree does (only flush the tlb on unmap) is just fine because it means that the only tlb entries in the remap area must belong to in-use mappings. Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com> Cc: Richard Henderson <rth@twiddle.net> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru> Cc: Russell King <rmk@arm.linux.org.uk> Cc: Mikael Starvik <starvik@axis.com> Cc: Andi Kleen <ak@suse.de> Cc: <linux-m32r@ml.linux-m32r.org> Cc: Ralf Baechle <ralf@linux-mips.org> Cc: Kyle McMartin <kyle@parisc-linux.org> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Paul Mundt <lethal@linux-sh.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Showing 1 changed file with 1 additions and 3 deletions Side-by-side Diff
lib/ioremap.c
... | ... | @@ -76,8 +76,6 @@ |
76 | 76 | |
77 | 77 | BUG_ON(addr >= end); |
78 | 78 | |
79 | - flush_cache_all(); | |
80 | - | |
81 | 79 | start = addr; |
82 | 80 | phys_addr -= addr; |
83 | 81 | pgd = pgd_offset_k(addr); |
... | ... | @@ -88,7 +86,7 @@ |
88 | 86 | break; |
89 | 87 | } while (pgd++, addr = next, addr != end); |
90 | 88 | |
91 | - flush_tlb_all(); | |
89 | + flush_cache_vmap(start, end); | |
92 | 90 | |
93 | 91 | return err; |
94 | 92 | } |