Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit de323f22a83b024b7432e813609c6efb74b1bbfc

Authored by akpm@linux-foundation.org
Committed by Michal Marek
1 parent a1087ef6ab
Exists in master and in 7 other branches imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

headers_check: better search for functions in headers 

Some headers don't bother with "extern" in function prototypes, which
results in said prototypes being unnoticed and exported to userland.

This patch slightly improves detection of such cases by checking for C
type names as well in the beginning of a line.

Signed-off-by: Alexander Shishkin <virtuoso@slind.org>
Cc: Stephen Hemminger <shemminger@vyatta.com>
Cc: Michal Marek <mmarek@suse.cz>
Cc: WANG Cong <amwang@redhat.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Michal Marek <mmarek@suse.cz>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

scripts/headers_check.pl
Diff comments   View file @ de323f2
... ... @@ -64,7 +64,7 @@
64 64  
65 65 sub check_declarations
66 66 {
67   - if ($line =~m/^\s*extern\b/) {
  67 + if ($line =~m/^(\s*extern|unsigned|char|short|int|long|void)\b/) {
68 68 printf STDERR "$filename:$lineno: " .
69 69 "userspace cannot call function or variable " .
70 70 "defined in the kernel\n";