Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit ec0c4274e33c0373e476b73e01995c53128f1257

Authored by Kees Cook
Committed by Thomas Gleixner
1 parent bdbb776f88
Exists in smarc-l5.0.0_1.0.0-ga and in 5 other branches imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga

futex: Mark get_robust_list as deprecated 

Notify get_robust_list users that the syscall is going away.

Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: Randy Dunlap <rdunlap@xenotime.net>
Cc: Darren Hart <dvhart@linux.intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Serge E. Hallyn <serge.hallyn@canonical.com>
Cc: kernel-hardening@lists.openwall.com
Cc: spender@grsecurity.net
Link: http://lkml.kernel.org/r/20120323190855.GA27213@www.outflux.net
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Showing 3 changed files with 14 additions and 0 deletions Side-by-side Diff

Documentation/feature-removal-schedule.txt
Diff comments   View file @ ec0c427
... ... @@ -529,4 +529,14 @@
529 529 Why: The old kmap_atomic() with two arguments is deprecated, we only
530 530 keep it for backward compatibility for few cycles and then drop it.
531 531 Who: Cong Wang <amwang@redhat.com>
  532 +
  533 +----------------------------
  534 +
  535 +What: get_robust_list syscall
  536 +When: 2013
  537 +Why: There appear to be no production users of the get_robust_list syscall,
  538 + and it runs the risk of leaking address locations, allowing the bypass
  539 + of ASLR. It was only ever intended for debugging, so it should be
  540 + removed.
  541 +Who: Kees Cook <keescook@chromium.org>
... ... @@ -2449,6 +2449,8 @@
2449 2449 if (!futex_cmpxchg_enabled)
2450 2450 return -ENOSYS;
2451 2451  
  2452 + WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n");
  2453 +
2452 2454 rcu_read_lock();
2453 2455  
2454 2456 ret = -ESRCH;
kernel/futex_compat.c
Diff comments   View file @ ec0c427
... ... @@ -142,6 +142,8 @@
142 142 if (!futex_cmpxchg_enabled)
143 143 return -ENOSYS;
144 144  
  145 + WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n");
  146 +
145 147 rcu_read_lock();
146 148  
147 149 ret = -ESRCH;