Commit ed13c27e546667fb0967ae30f5070cd7f6455f90

Authored by Chuck Lever
Committed by Trond Myklebust
1 parent 240ee83118

SUNRPC: Fix a memory leak in rpc_create()

Commit 510deb0d was supposed to move the xprt_create_transport() call in
rpc_create(), but neglected to remove the old call site.  This resulted in
a transport leak after every rpc_create() call.

This leak is present in 2.6.24 and 2.6.25.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

Showing 1 changed file with 0 additions and 4 deletions Side-by-side Diff

... ... @@ -261,10 +261,6 @@
261 261 };
262 262 char servername[48];
263 263  
264   - xprt = xprt_create_transport(&xprtargs);
265   - if (IS_ERR(xprt))
266   - return (struct rpc_clnt *)xprt;
267   -
268 264 /*
269 265 * If the caller chooses not to specify a hostname, whip
270 266 * up a string representation of the passed-in address.