Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit ed176886b68fbc450ddbe808684a142fcad72b56

Authored by Len Brown
Committed by Linus Torvalds
1 parent 67e17c1100
Exists in smarc-l5.0.0_1.0.0-ga and in 5 other branches imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga

ia64 idle: delete stale (*idle)() function pointer 

Commit 3e7fc708eb41 ("ia64 idle: delete pm_idle") in 3.9-rc1 didn't
finish the job, leaving an un-initialized reference to (*idle)().

[ Haven't seen a crash from this - but seems like we are just being
  lucky that "idle" is zero so it does get initialized before we jump to
  randomland  - Len ]

Reported-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Len Brown <len.brown@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 1 additions and 4 deletions Side-by-side Diff

arch/ia64/kernel/process.c
Diff comments   View file @ ed17688
... ... @@ -291,7 +291,6 @@
291 291 }
292 292  
293 293 if (!need_resched()) {
294   - void (*idle)(void);
295 294 #ifdef CONFIG_SMP
296 295 min_xtp();
297 296 #endif
... ... @@ -299,9 +298,7 @@
299 298 if (mark_idle)
300 299 (*mark_idle)(1);
301 300  
302   - if (!idle)
303   - idle = default_idle;
304   - (*idle)();
  301 + default_idle();
305 302 if (mark_idle)
306 303 (*mark_idle)(0);
307 304 #ifdef CONFIG_SMP