Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit efeb156e7275c5b6c6e0f96aceb3c6abf98fc392

Authored by Stephen Boyd
Committed by Linus Torvalds
1 parent a2ef990ab5
Exists in master and in 6 other branches imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

kprobes: silence DEBUG_STRICT_USER_COPY_CHECKS=y warning 

Enabling DEBUG_STRICT_USER_COPY_CHECKS causes the following warning:

  In file included from arch/x86/include/asm/uaccess.h:573,
                   from kernel/kprobes.c:55:
  In function 'copy_from_user',
      inlined from 'write_enabled_file_bool' at
      kernel/kprobes.c:2191:
  arch/x86/include/asm/uaccess_64.h:65:
  warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct

presumably due to buf_size being signed causing GCC to fail to see that
buf_size can't become negative.

Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
Cc: David S. Miller <davem@davemloft.net>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

... ... @@ -2198,7 +2198,7 @@
2198 2198 const char __user *user_buf, size_t count, loff_t *ppos)
2199 2199 {
2200 2200 char buf[32];
2201   - int buf_size;
  2201 + size_t buf_size;
2202 2202  
2203 2203 buf_size = min(count, (sizeof(buf)-1));
2204 2204 if (copy_from_user(buf, user_buf, buf_size))