Commit f0dfcde099453aa4c0dc42473828d15a6d492936
Committed by
Linus Torvalds
1 parent
d1f0ece6cd
Exists in
master
and in
6 other branches
kswapd: assign new_order and new_classzone_idx after wakeup in sleeping
There 2 places to read pgdat in kswapd. One is return from a successful balance, another is waked up from kswapd sleeping. The new_order and new_classzone_idx represent the balance input order and classzone_idx. But current new_order and new_classzone_idx are not assigned after kswapd_try_to_sleep(), that will cause a bug in the following scenario. 1: after a successful balance, kswapd goes to sleep, and new_order = 0; new_classzone_idx = __MAX_NR_ZONES - 1; 2: kswapd waked up with order = 3 and classzone_idx = ZONE_NORMAL 3: in the balance_pgdat() running, a new balance wakeup happened with order = 5, and classzone_idx = ZONE_NORMAL 4: the first wakeup(order = 3) finished successufly, return order = 3 but, the new_order is still 0, so, this balancing will be treated as a failed balance. And then the second tighter balancing will be missed. So, to avoid the above problem, the new_order and new_classzone_idx need to be assigned for later successful comparison. Signed-off-by: Alex Shi <alex.shi@intel.com> Acked-by: Mel Gorman <mgorman@suse.de> Reviewed-by: Minchan Kim <minchan.kim@gmail.com> Tested-by: Pádraig Brady <P@draigBrady.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Showing 1 changed file with 2 additions and 0 deletions Side-by-side Diff
mm/vmscan.c
... | ... | @@ -2887,6 +2887,8 @@ |
2887 | 2887 | balanced_classzone_idx); |
2888 | 2888 | order = pgdat->kswapd_max_order; |
2889 | 2889 | classzone_idx = pgdat->classzone_idx; |
2890 | + new_order = order; | |
2891 | + new_classzone_idx = classzone_idx; | |
2890 | 2892 | pgdat->kswapd_max_order = 0; |
2891 | 2893 | pgdat->classzone_idx = pgdat->nr_zones - 1; |
2892 | 2894 | } |