netfilter: bridge: refcount fix

commit f216f082b2b37c4943f1e7c393e2786648d48f6f ([NETFILTER]: bridge netfilter: deal with martians correctly) added a refcount leak on in_dev. Instead of using in_dev_get(), we can use __in_dev_get_rcu(), as netfilter hooks are running under rcu_read_lock(), as pointed by Patrick. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: Patrick McHardy <kaber@trash.net>

netfilter: bridge: refcount fix
commit f216f082b2b37c4943f1e7c393e2786648d48f6f ([NETFILTER]: bridge netfilter: deal with martians correctly) added a refcount leak on in_dev. Instead of using in_dev_get(), we can use __in_dev_get_rcu(), as netfilter hooks are running under rcu_read_lock(), as pointed by Patrick. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: Patrick McHardy <kaber@trash.net>
Eric Dumazet · Patrick McHardy
1 parent cce5a5c302
Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff
net/bridge/br_netfilter.c
@@ -359,7 +359,7 @@
 				},
 				.proto = 0,
 			};
-			struct in_device *in_dev = in_dev_get(dev);
+			struct in_device *in_dev = __in_dev_get_rcu(dev);
  
 			/* If err equals -EHOSTUNREACH the error is due to a
 			 * martian destination or due to the fact that
...	...	@@ -359,7 +359,7 @@
359	359	},
360	360	.proto = 0,
361	361	};
362		- struct in_device *in_dev = in_dev_get(dev);
	362	+ struct in_device *in_dev = __in_dev_get_rcu(dev);
363	363
364	364	/* If err equals -EHOSTUNREACH the error is due to a
365	365	* martian destination or due to the fact that