Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit f8a0697722d12a201588225999cfc8bfcbc82781

Authored by Vasiliy Kulikov
Committed by Samuel Ortiz
1 parent 90550d1903
Exists in master and in 7 other branches imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

mfd: ab3100: world-writable debugfs *_priv files 

Don't allow everybody to change device hardware registers.

Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>

Showing 1 changed file with 2 additions and 2 deletions Side-by-side Diff

drivers/mfd/ab3100-core.c
Diff comments   View file @ f8a0697
... ... @@ -613,7 +613,7 @@
613 613 ab3100_get_priv.ab3100 = ab3100;
614 614 ab3100_get_priv.mode = false;
615 615 ab3100_get_reg_file = debugfs_create_file("get_reg",
616   - S_IWUGO, ab3100_dir, &ab3100_get_priv,
  616 + S_IWUSR, ab3100_dir, &ab3100_get_priv,
617 617 &ab3100_get_set_reg_fops);
618 618 if (!ab3100_get_reg_file) {
619 619 err = -ENOMEM;
... ... @@ -623,7 +623,7 @@
623 623 ab3100_set_priv.ab3100 = ab3100;
624 624 ab3100_set_priv.mode = true;
625 625 ab3100_set_reg_file = debugfs_create_file("set_reg",
626   - S_IWUGO, ab3100_dir, &ab3100_set_priv,
  626 + S_IWUSR, ab3100_dir, &ab3100_set_priv,
627 627 &ab3100_get_set_reg_fops);
628 628 if (!ab3100_set_reg_file) {
629 629 err = -ENOMEM;