Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit fa7fe7af146a7b613e36a311eefbbfb5555325d1

Authored by Dan Carpenter
Committed by Greg Kroah-Hartman
1 parent 1d0f11b397
Exists in master and in 7 other branches imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

USB: fix testing the wrong variable in fs_create_by_name() 

There is a typo here.  We should be testing "*dentry" which was just
assigned instead of "dentry".  This could result in dereferencing an
ERR_PTR inside either usbfs_mkdir() or usbfs_create().

Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

Showing 1 changed file with 2 additions and 2 deletions Side-by-side Diff

drivers/usb/core/inode.c
Diff comments   View file @ fa7fe7a
... ... @@ -515,13 +515,13 @@
515 515 *dentry = NULL;
516 516 mutex_lock(&parent->d_inode->i_mutex);
517 517 *dentry = lookup_one_len(name, parent, strlen(name));
518   - if (!IS_ERR(dentry)) {
  518 + if (!IS_ERR(*dentry)) {
519 519 if ((mode & S_IFMT) == S_IFDIR)
520 520 error = usbfs_mkdir (parent->d_inode, *dentry, mode);
521 521 else
522 522 error = usbfs_create (parent->d_inode, *dentry, mode);
523 523 } else
524   - error = PTR_ERR(dentry);
  524 + error = PTR_ERR(*dentry);
525 525 mutex_unlock(&parent->d_inode->i_mutex);
526 526  
527 527 return error;