Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit fbbf8555a986ed31e54f006b6cc637ea4ff1425b

Authored by Nicholas Bellinger
1 parent fcf29481fb
Exists in smarc-l5.0.0_1.0.0-ga and in 5 other branches imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga

target: Add missing mapped_lun bounds checking during make_mappedlun setup 

This patch adds missing bounds checking for the configfs provided
mapped_lun value during target_fabric_make_mappedlun() setup ahead
of se_lun_acl initialization.

This addresses a potential OOPs when using a mapped_lun value that
exceeds the hardcoded TRANSPORT_MAX_LUNS_PER_TPG-1 value within
se_node_acl->device_list[].

Reported-by: Jan Engelhardt <jengelh@inai.de>
Cc: Jan Engelhardt <jengelh@inai.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

Showing 1 changed file with 8 additions and 0 deletions Side-by-side Diff

drivers/target/target_core_fabric_configfs.c
Diff comments   View file @ fbbf855
... ... @@ -354,6 +354,14 @@
354 354 ret = -EINVAL;
355 355 goto out;
356 356 }
  357 + if (mapped_lun > (TRANSPORT_MAX_LUNS_PER_TPG-1)) {
  358 + pr_err("Mapped LUN: %lu exceeds TRANSPORT_MAX_LUNS_PER_TPG"
  359 + "-1: %u for Target Portal Group: %u\n", mapped_lun,
  360 + TRANSPORT_MAX_LUNS_PER_TPG-1,
  361 + se_tpg->se_tpg_tfo->tpg_get_tag(se_tpg));
  362 + ret = -EINVAL;
  363 + goto out;
  364 + }
357 365  
358 366 lacl = core_dev_init_initiator_node_lun_acl(se_tpg, se_nacl,
359 367 mapped_lun, &ret);