Doug / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit fd24c4af6e82231391fa09875ae6378fa1399f0f

Authored by David S. Miller
1 parent ebbdbd7c02
Exists in master and in 7 other branches imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-l5.0.0_1.0.0-ga

sunhme: Remove stop/wake TX queue calls in set-multicast-list handler. 

Based upon a bug report by Alexander Beregalov and commentary
from Ben Hutchings.

These are totally unnecessary, in particular because this
driver's ->hard_start_xmit() handler takes the same driver
spinlock that the set-multicast-list handler uses.

Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 1 changed file with 0 additions and 4 deletions Side-by-side Diff

drivers/net/sunhme.c
Diff comments   View file @ fd24c4a
... ... @@ -2377,8 +2377,6 @@
2377 2377  
2378 2378 spin_lock_irq(&hp->happy_lock);
2379 2379  
2380   - netif_stop_queue(dev);
2381   -
2382 2380 if ((dev->flags & IFF_ALLMULTI) || (dev->mc_count > 64)) {
2383 2381 hme_write32(hp, bregs + BMAC_HTABLE0, 0xffff);
2384 2382 hme_write32(hp, bregs + BMAC_HTABLE1, 0xffff);
... ... @@ -2409,8 +2407,6 @@
2409 2407 hme_write32(hp, bregs + BMAC_HTABLE2, hash_table[2]);
2410 2408 hme_write32(hp, bregs + BMAC_HTABLE3, hash_table[3]);
2411 2409 }
2412   -
2413   - netif_wake_queue(dev);
2414 2410  
2415 2411 spin_unlock_irq(&hp->happy_lock);
2416 2412 }