04 Jun, 2013
1 commit
-
Current multiple-MSI implementation does not take into account actual
number of requested MSIs and always rounds that number to a larger
power-of-two value. Yet, the number of MSIs a PCI device could send (and
therefore the number of messages a device driver could request) may be
smaller. As result, resources allocated for extra MSIs are just wasted.This update takes advantage of 'msi_desc::nvec_used' field introduced with
generic MSI code to track the number of requested and used MSIs. As
result, resources associated with interrupts are conserved. Of those
resources most noticeable are x86 interrupt vectors.The initial version of this fix also conserved IRTEs, but Jan noticed that
a malfunctioning PCI device might send a message number it did not claim
and thus refer to an IRTE it does not own. To avoid this security hole,
as many IRTEs are reserved as the device could possibly send.[bhelgaas: changelog, rename to "nvec_used"]
Signed-off-by: Alexander Gordeev
Signed-off-by: Bjorn Helgaas
02 May, 2013
1 commit
18 Apr, 2013
1 commit
-
A few years back intel published a spec update:
http://www.intel.com/content/dam/doc/specification-update/5520-and-5500-chipset-ioh-specification-update.pdfFor the 5520 and 5500 chipsets which contained an errata (specificially errata
53), which noted that these chipsets can't properly do interrupt remapping, and
as a result the recommend that interrupt remapping be disabled in bios. While
many vendors have a bios update to do exactly that, not all do, and of course
not all users update their bios to a level that corrects the problem. As a
result, occasionally interrupts can arrive at a cpu even after affinity for that
interrupt has be moved, leading to lost or spurrious interrupts (usually
characterized by the message:
kernel: do_IRQ: 7.71 No irq handler for vector (irq -1)There have been several incidents recently of people seeing this error, and
investigation has shown that they have system for which their BIOS level is such
that this feature was not properly turned off. As such, it would be good to
give them a reminder that their systems are vulnurable to this problem. For
details of those that reported the problem, please see:
https://bugzilla.redhat.com/show_bug.cgi?id=887006[ Joerg: Removed CONFIG_IRQ_REMAP ifdef from early-quirks.c ]
Signed-off-by: Neil Horman
CC: Prarit Bhargava
CC: Don Zickus
CC: Don Dutile
CC: Bjorn Helgaas
CC: Asit Mallick
CC: David Woodhouse
CC: linux-pci@vger.kernel.org
CC: Joerg Roedel
CC: Konrad Rzeszutek Wilk
CC: Arkadiusz Miśkiewicz
Signed-off-by: Joerg Roedel
26 Mar, 2013
1 commit
-
Remove duplicated include.
Signed-off-by: Wei Yongjun
Signed-off-by: Joerg Roedel
28 Jan, 2013
13 commits
-
The irq_remapped function is only used in IOMMU code after
the last patch. So move its definition there too.Signed-off-by: Joerg Roedel
Acked-by: Sebastian Andrzej Siewior
Reviewed-by: Konrad Rzeszutek Wilk -
This callback replaces the old __eoi_ioapic_pin function
which needs a special path for interrupt remapping.Signed-off-by: Joerg Roedel
Acked-by: Sebastian Andrzej Siewior
Reviewed-by: Konrad Rzeszutek Wilk -
This call-back points to the right function for initializing
the msi_msg structure. The old code for msi_msg generation
was split up into the irq-remapped and the default case.The irq-remapped case just calls into the specific Intel or
AMD implementation when the device is behind an IOMMU.
Otherwise the default function is called.Signed-off-by: Joerg Roedel
Acked-by: Sebastian Andrzej Siewior
Reviewed-by: Konrad Rzeszutek Wilk -
This function does irq-remapping specific interrupt setup
like modifying the chip defaults.Signed-off-by: Joerg Roedel
Acked-by: Sebastian Andrzej Siewior
Reviewed-by: Konrad Rzeszutek Wilk -
The function is called unconditionally now in IO-APIC code
removing another irq_remapped() check from x86 core code.Signed-off-by: Joerg Roedel
Acked-by: Sebastian Andrzej Siewior
Reviewed-by: Konrad Rzeszutek Wilk -
Move all the code to either to the header file
asm/irq_remapping.h or to drivers/iommu/.Signed-off-by: Joerg Roedel
Acked-by: Sebastian Andrzej Siewior
Reviewed-by: Konrad Rzeszutek Wilk -
Move these checks to IRQ remapping code by introducing the
panic_on_irq_remap() function.Signed-off-by: Joerg Roedel
Acked-by: Sebastian Andrzej Siewior
Reviewed-by: Konrad Rzeszutek Wilk -
This pointer is changed to a different function when IRQ
remapping is enabled.Signed-off-by: Joerg Roedel
Acked-by: Sebastian Andrzej Siewior
Reviewed-by: Konrad Rzeszutek Wilk -
With interrupt remapping a special function is used to
change the affinity of an IO-APIC interrupt. Abstract this
with a function pointer.Signed-off-by: Joerg Roedel
Acked-by: Sebastian Andrzej Siewior
Reviewed-by: Konrad Rzeszutek Wilk -
Use seperate routines to setup MSI IRQs for both
irq_remapping_enabled cases.Signed-off-by: Joerg Roedel
Acked-by: Sebastian Andrzej Siewior
Reviewed-by: Konrad Rzeszutek Wilk -
This function pointer can be overwritten by the IRQ
remapping code. The irq_remapping_enabled check can be
removed from default_setup_hpet_msi.Signed-off-by: Joerg Roedel
Acked-by: Sebastian Andrzej Siewior
Reviewed-by: Konrad Rzeszutek Wilk -
This function pointer is used to call a system-specific
function for disabling the IO-APIC. Currently this is used
for IRQ remapping which has its own disable routine.Also introduce the necessary infrastructure in the interrupt
remapping code to overwrite this and other function pointers
as necessary by interrupt remapping.Signed-off-by: Joerg Roedel
Acked-by: Sebastian Andrzej Siewior
Reviewed-by: Konrad Rzeszutek Wilk -
Move the three easy to move checks in the x86' apic.c file
into the IRQ-remapping code.Signed-off-by: Joerg Roedel
Acked-by: Sebastian Andrzej Siewior
Reviewed-by: Konrad Rzeszutek Wilk
28 Sep, 2012
1 commit
-
Finally enable interrupt remapping for AMD systems.
Signed-off-by: Joerg Roedel
25 Jul, 2012
1 commit
-
Pull IOMMU updates from Joerg Roedel:
"The most important part of these updates is the IOMMU groups code
enhancement written by Alex Williamson. It abstracts the problem that
a given hardware IOMMU can't isolate any given device from any other
device (e.g. 32 bit PCI devices can't usually be isolated). Devices
that can't be isolated are grouped together. This code is required
for the upcoming VFIO framework.Another IOMMU-API change written by me is the introduction of domain
attributes. This makes it easier to handle GART-like IOMMUs with the
IOMMU-API because now the start-address and the size of the domain
address space can be queried.Besides that there are a few cleanups and fixes for the NVidia Tegra
IOMMU drivers and the reworked init-code for the AMD IOMMU. The
latter is from my patch-set to support interrupt remapping. The rest
of this patch-set requires x86 changes which are not mergabe yet. So
full support for interrupt remapping with AMD IOMMUs will come in a
future merge window."* tag 'iommu-updates-v3.6-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu: (33 commits)
iommu/amd: Fix hotplug with iommu=pt
iommu/amd: Add missing spin_lock initialization
iommu/amd: Convert iommu initialization to state machine
iommu/amd: Introduce amd_iommu_init_dma routine
iommu/amd: Move unmap_flush message to amd_iommu_init_dma_ops()
iommu/amd: Split enable_iommus() routine
iommu/amd: Introduce early_amd_iommu_init routine
iommu/amd: Move informational prinks out of iommu_enable
iommu/amd: Split out PCI related parts of IOMMU initialization
iommu/amd: Use acpi_get_table instead of acpi_table_parse
iommu/amd: Fix sparse warnings
iommu/tegra: Don't call alloc_pdir with as->lock
iommu/tegra: smmu: Fix unsleepable memory allocation at alloc_pdir()
iommu/tegra: smmu: Remove unnecessary sanity check at alloc_pdir()
iommu/exynos: Implement DOMAIN_ATTR_GEOMETRY attribute
iommu/tegra: Implement DOMAIN_ATTR_GEOMETRY attribute
iommu/msm: Implement DOMAIN_ATTR_GEOMETRY attribute
iommu/omap: Implement DOMAIN_ATTR_GEOMETRY attribute
iommu/vt-d: Implement DOMAIN_ATTR_GEOMETRY attribute
iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute
...
17 Jul, 2012
1 commit
-
A few sparse warnings fire in drivers/iommu/amd_iommu_init.c.
Fix most of them with this patch. Also fix the sparse
warnings in drivers/iommu/irq_remapping.c while at it.Signed-off-by: Joerg Roedel
15 Jun, 2012
1 commit
-
Move the ->irq_set_affinity() routines out of the #ifdef CONFIG_SMP
sections and use config_enabled(CONFIG_SMP) checks inside those
routines. Thus making those routines simple null stubs for
!CONFIG_SMP and retaining those routines with no additional
runtime overhead for CONFIG_SMP kernels.Cleans up the ifdef CONFIG_SMP in and around routines related to
irq_set_affinity in io_apic and irq_remapping subsystems.Signed-off-by: Suresh Siddha
Cc: torvalds@linux-foundation.org
Cc: joerg.roedel@amd.com
Cc: Sam Ravnborg
Cc: Paul Gortmaker
Link: http://lkml.kernel.org/r/1339723729.3475.63.camel@sbsiddha-desk.sc.intel.com
Signed-off-by: Ingo Molnar
08 May, 2012
1 commit
-
Fix the below UP build failure with CONFIG_IRQ_REMAP enabled.
drivers/iommu/intel_irq_remapping.c:955:19: error: ‘struct irq_data’ has no member named ‘affinity’
Reported-by: Ingo Molnar
Signed-off-by: Suresh Siddha
Cc: joro@8bytes.org
Cc: iommu@lists.linux-foundation.org
Cc: Joerg Roedel
Link: http://lkml.kernel.org/r/1336460934-23592-2-git-send-email-suresh.b.siddha@intel.com
Signed-off-by: Ingo Molnar
07 May, 2012
1 commit
-
Make the file names consistent with the naming conventions of irq subsystem.
Signed-off-by: Suresh Siddha
Cc: Joerg Roedel
Cc: Yinghai Lu
Cc: David Woodhouse
Cc: Alex Williamson
Signed-off-by: Joerg Roedel