08 Jan, 2013
40 commits
-
we should check the return value of calling function fir16_create(): a NULL
value means the memory allocation fails.this patch also cleans up the error handling in function function oslec_create()
Signed-off-by: Cong Ding
Signed-off-by: Greg Kroah-Hartman -
In uf_send_pkt_to_encrypt(), the memory area zeroed by this call to memset() is
overwritten by a call to memcpy() a few instructions later, so it is not needed.Signed-off-by: Cyril Roelandt
Signed-off-by: Greg Kroah-Hartman -
the variable j isn't used in the loop
Signed-off-by: Cong Ding
Signed-off-by: Greg Kroah-Hartman -
line6_send_sysex_message_async() isn't called from anywhere.
Signed-off-by: Dan Carpenter
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Johannes Thumshirn
Signed-off-by: Greg Kroah-Hartman -
staging: line6: driver.c
The semantic patch that makes this output is available
in scripts/coccinelle/api/memdup.cocci.Signed-off-by: Laurent Navet
Signed-off-by: Greg Kroah-Hartman -
fix those checkpatch issues
drivers/staging/line6/pcm.c:84:
WARNING: simple_strtoul is obsolete, use kstrtoul instead
call to obsolete simple_strtoul() replaced by kstrtoint()drivers/staging/line6/pcm.c:423:
ERROR: switch and case should be at the same indent
realigns commentsSigned-off-by: Laurent Navet
Signed-off-by: Greg Kroah-Hartman -
Fixed a coding style issue. Fixed positions
of braces regarding to linux coding style.Signed-off-by: Kurt Kanzenbach
Acked-by: Dan Carpenter
Signed-off-by: Greg Kroah-Hartman -
Fixed a coding style issue. Removed trailing
whitespaces in code.Signed-off-by: Kurt Kanzenbach
Acked-by: Dan Carpenter
Signed-off-by: Greg Kroah-Hartman -
Fixed a coding style issue. Replaced all
c99 comments by c89 ones and deleted
commented out code.Signed-off-by: Kurt Kanzenbach
Acked-by: Dan Carpenter
Signed-off-by: Greg Kroah-Hartman -
Fix the checkpatch error "do not initialize statics to 0 or NULL"
Signed-off-by: Sebastian Hahn
Signed-off-by: Greg Kroah-Hartman -
Fix the checkpatch error "switch and case should be at the same indent"
Signed-off-by: Sebastian Hahn
Signed-off-by: Greg Kroah-Hartman -
Fix a couple of instances where checkpatch complained about
initializing globals with 0.Signed-off-by: Sebastian Hahn
Signed-off-by: Greg Kroah-Hartman -
Converted staging/rtl8187se to use tabs instead of spaces for
indentation to fix the checkpatch error "code indent should use tabs
where possible".Signed-off-by: Sebastian Hahn
Signed-off-by: Greg Kroah-Hartman -
This fixes the checkpatch error "open brace '{' following struct go on the
same line" in staging/rtl8192uSigned-off-by: Jennifer Naumann
Signed-off-by: Greg Kroah-Hartman -
Run cleanfile on all files inside drivers/staging/rtl819u
Signed-off-by: Sebastian Hahn
Signed-off-by: Jennifer Naumann
Signed-off-by: Greg Kroah-Hartman -
The following errors fixed.
- ERROR: "foo * bar" should be "foo *bar"
- ERROR: "(foo*)" should be "(foo *)"Signed-off-by: YAMANE Toshiaki
Signed-off-by: Greg Kroah-Hartman -
The following errors and warnings fixed.
- WARNING: braces {} are not necessary for single statement blocks
- ERROR: that open brace { should be on the previous line
- ERROR: space required before the open parenthesis '('
- ERROR: space prohibited after that open parenthesis '('Signed-off-by: YAMANE Toshiaki
Signed-off-by: Greg Kroah-Hartman -
The following errors fixed.
- ERROR: spaces required around that '=' (ctx:VxV)
- ERROR: spaces required around that '
Signed-off-by: Greg Kroah-Hartman -
The following warnings fixed.
-WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...
-WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...Signed-off-by: YAMANE Toshiaki
Signed-off-by: Greg Kroah-Hartman -
The following errors fixed.
-ERROR: spaces required around that '' (ctx:VxV)Signed-off-by: YAMANE Toshiaki
Signed-off-by: Greg Kroah-Hartman -
The following errors fixed.
-ERROR: that open brace { should be on the previous line
-ERROR: space required before the open parenthesis '('
-ERROR: else should follow close brace '}'
-ERROR: space required before the open brace '{'Signed-off-by: YAMANE Toshiaki
Signed-off-by: Greg Kroah-Hartman -
The following errors and warnings fixed.
- ERROR: code indent should use tabs where possible
- WARNING: please, no spaces at the start of a line
- WARNING: please, no space before tabsSigned-off-by: YAMANE Toshiaki
Signed-off-by: Greg Kroah-Hartman -
If mkdir() of VHCI_STATE_PATH fails because the directory
already exists, that's not an error. This patch fixes
annoying "record connection" errors that would typically
come up on attach.Signed-off-by: Ilija Hadzic
Acked-by: David Chang
Signed-off-by: Greg Kroah-Hartman -
This comes handy when hacking with different cross
compilers, some of which may or may not have
_FORTIFY_SOURCE turned on by default. This patch
allows us to turn _FORTIFY_SOURCE on by specifying
--with-fortify option at configuration time (or
to turn it off by specifying --without-fortify).If nothing is specified, default compiler behavior
is assumed.Signed-off-by: Ilija Hadzic
Signed-off-by: Greg Kroah-Hartman -
USBIP daemon relies on functions available in glib2 library
to spawn handler code for incoming connection. This makes the
whole program dependent on glib2 library, which is a GNOME library
that on systems that don't have GNOME results in pulling more
dependency, only to be able to run a relatively trivial
socket-based program.While this may not seem to be a problem on full-blown desktops
that already have the necessary libraries, it is a big issue
on small embedded systems (think USB hub with an Ethernet port)
that only have bare essentials in their file systems.This patch eliminates glib2 dependency by reworking the
code to use lower level system calls to dispatch connection
handler. Instead of using glib2-style event loop and dispatching
mechanism, just do a ppoll(2) system call in our own loop and call
accept(2) followed by fork(2) on the socket that has incoming
connection. Stevens' books taught us that more than twenty
years ago. No need for anything smarter in a simple server, such
as usbipd.Signed-off-by: Ilija Hadzic
Signed-off-by: Greg Kroah-Hartman -
There are a bunch of automatically generated files that git
should not care about.Signed-off-by: Ilija Hadzic
Signed-off-by: Greg Kroah-Hartman -
File doc/usbip_bind_driver.8 does not exist any more but it is
listed in dist_man_MANS. This breaks the build of the userspace.
Remove the file from the list.Signed-off-by: Ilija Hadzic
Acked-by: David Chang
Signed-off-by: Greg Kroah-Hartman -
strict_strtoul is obsolete and should be replaced with
kstrto* function as reported by checkpatch.pl.
pInfo->CardNumber is a u8. This is why kstrtou8 should be
used here.Signed-off-by: Kurt Kanzenbach
Signed-off-by: Greg Kroah-Hartman -
After unifying struct ft1000_info, struct ft1000_device is now wrong name.
Rename it to ft1000_usb to match its semantics.Signed-off-by: Ondrej Zary
Reviewed-by: Marek Belisko
Signed-off-by: Greg Kroah-Hartman -
Unify struct ft1000_info between ft1000-usb and ft1000-pcmcia and move it to
common ft1000.h.Signed-off-by: Ondrej Zary
Tested-by: Marek Belisko
Review-by: Marek Belisko
Signed-off-by: Greg Kroah-Hartman -
Correct spelling typo in comments within vt6655 driver.
Signed-off-by: Masanari Iida
Signed-off-by: Greg Kroah-Hartman -
This call is followed by a call to memcpy() on the same memory area, so it can
be safely removed.Signed-off-by: Cyril Roelandt
Acked-by: Marcos Paulo de Souza
Signed-off-by: Greg Kroah-Hartman -
This patch cleans up function declarations, definitions and local variables
where appropriate replacing types defined in "ttype.h" with linux/types.h.Signed-off-by: Malcolm Priestley
Signed-off-by: Greg Kroah-Hartman -
This patch cleans up function declarations, definitions and local variables
were appropriate replacing types defined in "ttype.h" with linux/types.hSigned-off-by: Malcolm Priestley
Signed-off-by: Greg Kroah-Hartman -
This patch cleans up function declarations, definitions and local variables
were appropriate replacing types defined in "ttype.h" with linux/types.h.Signed-off-by: Malcolm Priestley
Signed-off-by: Greg Kroah-Hartman -
This patch also cleans up function declarations, definitions and local variables
were appropriate replacing types defined in "ttype.h" with linux/types.h.Signed-off-by: Malcolm Priestley
Signed-off-by: Greg Kroah-Hartman -
This patch also cleans up function declarations, definitions and local variables
were appropriate replacing types defined in "ttype.h" with linux/types.h.Signed-off-by: Malcolm Priestley
Signed-off-by: Greg Kroah-Hartman -
This patch and the next 8 patches remove the old structure names and
replace;struct vnt_private for DEVICE_INFO and PSDevice
struct vnt_manager for SMgmtObject
struct vnt_rx_mgmt for SRxMgmtPacket and PSRxMgmtPacket
struct vnt_tx_mgmt for STxMgmtPacket and PSTxMgmtPacketand
struct vnt_manager vnt_mgmt
to replace
SMgmtObject sMgmtObj;Applied after patch staging: vt6656: dpc.c :RXbBulkInProcessData clean up RSC
Signed-off-by: Malcolm Priestley
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Malcolm Priestley
Signed-off-by: Greg Kroah-Hartman -
A few lines after this call, we memcpy over the same memory area, so the call to
memset is not necessary.Signed-off-by: Cyril Roelandt
Signed-off-by: Greg Kroah-Hartman