21 Mar, 2006
40 commits
-
Stupidly use kzalloc() instead of kmalloc()/memset()
everywhere where this is possible in net/ipv6/*.c .Signed-off-by: Ingo Oeser
Signed-off-by: David S. Miller -
Two minor cleanups:
1. Using kzalloc() in fraq_alloc_queue()
saves the memset() in ipv6_frag_create().2. Invert sense of if-statements to streamline code.
Inverts the comment, too.Signed-off-by: Ingo Oeser
Signed-off-by: David S. Miller -
Signed-off-by: Andrew Morton
Signed-off-by: David S. Miller -
The Coverity checker noted this inconsequent NULL checking in
dnrt_drop().Since all callers ensure that NULL isn't passed, we can simply remove
the check.Signed-off-by: Adrian Bunk
Signed-off-by: David S. Miller -
This patch makes the needlessly global function tg3_request_irq()
static.Signed-off-by: Adrian Bunk
Signed-off-by: David S. Miller -
The bridge code can use existing LLC output code when building
spanning tree protocol packets.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Cleanup of LLC. llc_mac_hdr_init can take constant arguments,
and it is defined twice once in llc_output.h that is otherwise unused.Signed-off-by: Stephen Hemminger
Acked-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Bridge's communicate with each other using Spanning Tree Protocol
over a standard multicast address. There are times when testing or
layering bridges over existing topologies or tunnels, when it is
useful to use alternative multicast addresses for STP packets.The 802.1d standard has some unused addresses, that can be used for this.
This patch is restrictive in that it only allows one of the possible
addresses in the standard.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Use LLC for the receive path of Spanning Tree Protocol packets.
This allows link local multicast packets to be received by
other protocols (if they care), and uses the existing LLC
code to get STP packets back into bridge code.The bridge multicast address is also checked, so bridges using
other link local multicast addresses are ignored. This allows
for use of different multicast addresses to define separate STP
domains.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Cleanup the get/set of bridge timer value in the packets.
It is clearer not to bury the conversion in macro.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Optimize the forwarding and transmit paths. Both places are
called with bottom half/no preempt so there is no need to use
spin_lock_bh or rcu_read_lock.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Move nf_bridge_alloc from header file to the one place it is
used and optimize it.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Fix the VLAN macros in bridge netfilter code. Macros should
not depend on magic variables.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Only use__constant_htons() for initializers and switch cases.
For other uses, it is just as efficient and clearer to use htonsSigned-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Run br_netfilter through Lindent to fix whitespace.
Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
The netfilter hook that is used to receive frames doesn't need to be a
stub. It is only called in two ways, both of which ignore the return
value.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Use kzalloc versus kmalloc+memset. Also don't need to do
memset() of bridge address since it is in netdev private data
that is already zero'd in alloc_netdev.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Use kcalloc rather than kmalloc + memset.
Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Use the now standard setup_timer function.
Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
The STP timers run off softirq (kernel timers), so there is no need to
disable bottom half in the spin locks.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
net/bridge/br_netfilter.c: In function `br_nf_pre_routing':
net/bridge/br_netfilter.c:427: warning: unused variable `vhdr'
net/bridge/br_netfilter.c:445: warning: unused variable `vhdr'Signed-off-by: Andrew Morton
Signed-off-by: David S. Miller -
net/bridge/netfilter/ebtables.c:1481: warning: initialization makes pointer from integer without a cast
Signed-off-by: Andrew Morton
Signed-off-by: David S. Miller -
Sparc64 and Sparc32 have to have identical socket call
numbering in order to handle compat layer stuff properly.Signed-off-by: David S. Miller
-
"struct inet_csk" --> "struct inet_connection_sock" :-)
Signed-off-by: David S. Miller
-
This is in preparation for having a dccp_minisock embedded into
dccp_request_sock so that feature negotiation can be done prior to
creating the full blown dccp_sock.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
This will later be included in struct dccp_request_sock so that we can
have per connection feature negotiation state while in the 3way
handshake, when we clone the DCCP_ROLE_LISTEN socket (in
dccp_create_openreq_child) we'll just copy this state from
dreq_minisock to dccps_minisock.Also the feature negotiation and option parsing code will mostly touch
dccps_minisock, which will simplify some stuff.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Signed-off-by: Catherine Zhang
Signed-off-by: Arnaldo Carvalho de Melo -
No code changes, just tidying up, in some cases moving EXPORT_SYMBOLs
to just after the function exported, etc.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
*** Warning: "skb_pull_rcsum" [net/bridge/bridge.ko] undefined!
*** Warning: "skb_pull_rcsum" [net/8021q/8021q.ko] undefined!
*** Warning: "skb_pull_rcsum" [drivers/net/pppoe.ko] undefined!
*** Warning: "skb_pull_rcsum" [drivers/net/ppp_generic.ko] undefined!Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
A recent changeset removes dummy_socket_getpeersec, replacing it with
two new functions, but still references the removed function in the
security_fixup_ops table, fix it by doing the replacement operation in
the fixup table too.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
This patch extends {get|set}sockopt compatibility layer in order to
move protocol specific parts to their place and avoid huge universal
net/compat.c file in the future.Signed-off-by: Dmitry Mishin
Signed-off-by: David S. Miller -
We've already dereferenced 'np' a dozen
times at this point, so it's safe to say it's not null.Signed-off-by: Dave Jones
Signed-off-by: David S. Miller -
This option should IMHO no longer depend on EXPERIMENTAL.
Signed-off-by: Adrian Bunk
ACKed-by: Jamal Hadi Salim
Signed-off-by: David S. Miller -
We're now starting to have quite a number of places that do skb_pull
followed immediately by an skb_postpull_rcsum. We can merge these two
operations into one function with skb_pull_rcsum. This makes sense
since most pull operations on receive skb's need to update the
checksum.I've decided to make this out-of-line since it is fairly big and the
fast path where hardware checksums are enabled need to call
csum_partial anyway.Since this is a brand new function we get to add an extra check on the
len argument. As it is most callers of skb_pull ignore its return
value which essentially means that there is no check on the len
argument.Signed-off-by: Herbert Xu
Signed-off-by: David S. Miller -
As per Robert Olsson's patch for ipv4, this is the DECnet
version to keep the code "in step". It changes the list
of rules to use RCU rather than an rwlock.Inspired-by: Robert Olsson
Signed-off-by: Steven Whitehouse
Signed-off-by: Patrick Caulfield
Signed-off-by: David S. Miller -
This patch means that 64bit kernel/32bit userland platforms will now
work correctly with DECnet.Signed-off-by: Patrick Caulfield
Signed-off-by: Steven Whitehouse
Signed-off-by: David S. Miller -
The typedef for dn_address has been removed in favour of using __le16
or __u16 directly as appropriate. All the DECnet header files are
updated accordingly.The byte ordering of dn_eth2dn() and dn_dn2eth() are both changed
since just about all their callers wanted network order rather than
host order, so the conversion is now done in the functions themselves.Several missed endianess conversions have been picked up during the
conversion process. The nh_gw field in struct dn_fib_info has been
changed from a 32 bit field to 16 bits as it ought to be.One or two cases of using htons rather than dn_htons in the routing
code have been found and fixed.There are still a few warnings to fix, but this patch deals with the
important cases.Signed-off-by: Steven Whitehouse
Signed-off-by: Patrick Caulfield
Signed-off-by: David S. Miller
