05 Aug, 2010
1 commit
-
commit 3d0518f4, "ext4: New rec_len encoding for very
large blocksizes" made several changes to this path, but from
a perf perspective, un-inlining ext4_rec_len_from_disk() seems
most significant. This function is called from ext4_check_dir_entry(),
which on a file-creation workload is called extremely often.I tested this with bonnie:
# bonnie++ -u root -s 0 -f -x 200 -d /mnt/test -n 32
(this does 200 iterations) and got this for the file creations:
ext4 stock: Average = 21206.8 files/s
ext4 inlined: Average = 22346.7 files/s (+5%)Signed-off-by: Eric Sandeen
Signed-off-by: "Theodore Ts'o"
04 Aug, 2010
2 commits
-
This should remove the last exclusive lock from start_this_handle(),
so that we should now be able to start multiple transactions at the
same time on large SMP systems.Signed-off-by: "Theodore Ts'o"
-
Lockstat reports have shown that j_state_lock is a major source of
lock contention, especially on systems with more than 4 CPU cores. So
change it to be a read/write spinlock.Signed-off-by: "Theodore Ts'o"
02 Aug, 2010
4 commits
-
By using an atomic_t for t_updates and t_outstanding credits, this
should allow us to not need to take transaction t_handle_lock in
jbd2_journal_stop().Signed-off-by: "Theodore Ts'o"
-
Allow mount options to be stored in the superblock. Also add default
mount option bits for nobarrier, block_validity, discard, and nodelalloc.Signed-off-by: "Theodore Ts'o"
-
Perform full sync procedure so that any delayed allocation blocks are
allocated so quota will be consistent.Signed-off-by: Dmitry Monakhov
Signed-off-by: "Theodore Ts'o" -
Commit 6b0310fbf087ad6 caused a regression resulting in deadlocks
when freezing a filesystem which had active IO; the vfs_check_frozen
level (SB_FREEZE_WRITE) did not let the freeze-related IO syncing
through. Duh.Changing the test to FREEZE_TRANS should let the normal freeze
syncing get through the fs, but still block any transactions from
starting once the fs is completely frozen.I tested this by running fsstress in the background while periodically
snapshotting the fs and running fsck on the result. I ran into
occasional deadlocks, but different ones. I think this is a
fine fix for the problem at hand, and the other deadlocky things
will need more investigation.Reported-by: Phillip Susi
Signed-off-by: Eric Sandeen
Signed-off-by: "Theodore Ts'o"
30 Jul, 2010
1 commit
-
There were some error paths in ext4_delete_inode() which was not
dropping the inode from the orphan list. This could lead to a BUG_ON
on umount when the orphan list is discovered to be non-empty.Signed-off-by: "Theodore Ts'o"
27 Jul, 2010
21 commits
-
There are some drivers which may not set bdev->bd_dev. So make sure
it is non-NULL before dereferencing it.Google-Bug-Id: 1773557
Signed-off-by: "Theodore Ts'o"
-
Saying things like "sync failed" when a device does
not support barriers makes users slightly more worried than
they need to be; rather than talking about sync failures,
let's just state the barrier-based facts.Signed-off-by: Eric Sandeen
Signed-off-by: "Theodore Ts'o" -
I often get emails containing the "This should not happen!!" message,
conveniently trimmed to remove things like:sd 0:0:0:0: [sda] Unhandled error code
sd 0:0:0:0: [sda] Result: hostbyte=DID_OK driverbyte=DRIVER_TIMEOUT
sd 0:0:0:0: [sda] CDB: Write(10): 2a 00 03 13 c9 70 00 00 28 00
end_request: I/O error, dev sda, sector 51628400
Aborting journal on device dm-0-8.
EXT4-fs error (device dm-0): ext4_journal_start_sb: Detected aborted journal
EXT4-fs (dm-0): Remounting filesystem read-onlyI don't think there is any value to the verbosity if the reason is
due to a filesystem abort; it just obfuscates the root cause.Signed-off-by: Eric Sandeen
Signed-off-by: "Theodore Ts'o" -
By running the following reproducer, we can confirm that the write
system call returns with 0 when it should return the error EFBIG.#!/bin/sh
/bin/dd if=/dev/zero of=./img bs=1k count=1 seek=1024k > /dev/null 2>&1
/sbin/mkfs.ext3 -Fq ./img
/bin/mount -o loop -t ext4 ./img /mnt
/bin/touch /mnt/file
strace /bin/dd if=/dev/zero of=/mnt/file conv=notrunc bs=1k count=1 seek=$((2194719883264/1024)) 2>&1 | /bin/egrep "write.* 1024\) = "
/bin/umount /mnt
exitSigned-off-by: Toshiyuki Okajima
Signed-off-by: "Theodore Ts'o"
Cc: Eric Sandeen -
ext4_get_blocks got renamed to ext4_map_blocks, but left stale
comments and a prototype littered around.Signed-off-by: Eric Sandeen
Signed-off-by: "Theodore Ts'o" -
When journaled quota options are not specified, we do writes
to quota files just in data=ordered mode. This actually causes
warnings from JBD2 about dirty journaled buffer because ext4_getblk
unconditionally treats a block allocated by it as metadata. Since
quota actually is filesystem metadata, the easiest way to get rid
of the warning is to always treat quota writes as metadata...Signed-off-by: Jan Kara
Signed-off-by: "Theodore Ts'o" -
Under heavy memory pressure we may hit out of memory
situation and as result kstrdup'ed options will not be
freed. Fix it.Signed-off-by: Cyrill Gorcunov
Signed-off-by: "Theodore Ts'o" -
If the user attempts to make a non-extent-mapped file to be too large,
return EFBIG, but don't call ext4_std_err() which will end up marking
the file system as containing an error.Thanks to Toshiyuki Okajima-san at Fujitsu for pointing this out.
Signed-off-by: "Theodore Ts'o"
-
For some reason, today mballoc only allocates IOs which are exactly
stripe-sized on a stripe boundary. If you have a multiple (say, a
128k IO on a 64k stripe) you may end up unaligned.It seems to me that a simple change to align stripe-multiple IOs
on stripe boundaries would be a very good idea, unless this breaks
some other mballoc heuristic for some reason...Reported-by: Mike Snitzer
Signed-off-by: Eric Sandeen
Signed-off-by: "Theodore Ts'o" -
This patch is to be applied upon Christoph's "direct-io: move aio_complete
into ->end_io" patch. It adds iocb and result fields to struct ext4_io_end_t,
so that we can call aio_complete from ext4_end_io_nolock() after the extent
conversion has finished.I have verified with Christoph's aio-dio test that used to fail after a few
runs on an original kernel but now succeeds on the patched kernel.See http://thread.gmane.org/gmane.comp.file-systems.ext4/19659 for details.
Signed-off-by: Jiaying Zhang
Signed-off-by: "Theodore Ts'o" -
Filesystems with unwritten extent support must not complete an AIO request
until the transaction to convert the extent has been commited. That means
the aio_complete calls needs to be moved into the ->end_io callback so
that the filesystem can control when to call it exactly.This makes a bit of a mess out of dio_complete and the ->end_io callback
prototype even more complicated.Signed-off-by: Christoph Hellwig
Reviewed-by: Jan Kara
Signed-off-by: "Theodore Ts'o" -
Issue discard request in ext4_free_blocks() when ext4 has no journal and
is mounted with discard option.Signed-off-by: Jiaying Zhang
Signed-off-by: "Theodore Ts'o" -
__GFP_NOFAIL is going away, so add our own retry loop. Also add
jbd2__journal_start() and jbd2__journal_restart() which take a gfp
mask, so that file systems can optionally (re)start transaction
handles using GFP_KERNEL. If they do this, then they need to be
prepared to handle receiving an PTR_ERR(-ENOMEM) error, and be ready
to reflect that error up to userspace.Signed-off-by: "Theodore Ts'o"
-
We have experienced bitmap inconsistencies after crash during file
delete under heavy load. The crash is not file system related and I
the following patch in ext4_free_branches() fixes the recovery
problem.If the transaction is restarted and there is a crash before the new
transaction is committed, then after recovery, the blocks that this
indirect block points to have been freed, but the indirect block
itself has not been freed and may still point to some of the free
blocks (because of the ext4_forget()).So ext4_forget() should be called inside ext4_free_blocks() to avoid
this problem.Signed-off-by: Amir Goldstein
Signed-off-by: "Theodore Ts'o" -
Signed-off-by: Joe Perches
Signed-off-by: "Theodore Ts'o" -
The allocation_context pointer can be NULL.
Signed-off-by: "Theodore Ts'o"
-
This has been in use by e2fsprogs for a while; define it to keep the
super block fields in sync.Signed-off-by: "Theodore Ts'o"
-
This allows us to grab any file system error messages by scraping
/var/log/messages. This will make it easy for us to do error analysis
across the very large number of machines as we deploy ext4 across the
fleet.Signed-off-by: "Theodore Ts'o"
-
Save number of file system errors, and the time function name, line
number, block number, and inode number of the first and most recent
errors reported on the file system in the superblock.Signed-off-by: "Theodore Ts'o"
-
Signed-off-by: "Theodore Ts'o"
-
Also start passing the line number to ext4_check_dir since we're going
to need it in upcoming patch.Signed-off-by: "Theodore Ts'o"
30 Jun, 2010
2 commits
-
This allows the error messages to include the line number
Signed-off-by: "Theodore Ts'o"
-
Also use a macro definition so that __func__ and __LINE__ is implicit.
Signed-off-by: "Theodore Ts'o"
29 Jun, 2010
2 commits
-
Use a macro definition for ext4_abort() to clean up the .c files a wee
bit.Signed-off-by: "Theodore Ts'o"
-
Signed-off-by: "Theodore Ts'o"
16 Jun, 2010
1 commit
-
ext4 didn't update the ctime of the file when its permission was
changed.Steps to reproduce:
# touch aaa
# stat -c %Z aaa
1275289822
# setfacl -m 'u::x,g::x,o::x' aaa
# stat -c %Z aaa
1275289822 .CC: linux-ext4@vger.kernel.org
Signed-off-by: Jan Kara
Signed-off-by: "Theodore Ts'o"
15 Jun, 2010
2 commits
-
The nobh option was only supported for writeback mode, but given that all
write paths actually create buffer heads it effectively was a no-op already.Signed-off-by: Christoph Hellwig
Signed-off-by: "Theodore Ts'o" -
No real bugs found, just removed some dead code.
Found by gcc 4.6's new warnings.
Signed-off-by: Andi Kleen
Signed-off-by: "Theodore Ts'o"
14 Jun, 2010
1 commit
-
These changes are not ones which are likely to result in races, but
they should be fixed.Signed-off-by: "Theodore Ts'o"
12 Jun, 2010
3 commits
-
We don't need to set s_dirt in most of the ext4 code when journaling
is enabled. In ext3/4 some of the summary statistics for # of free
inodes, blocks, and directories are calculated from the per-block
group statistics when the file system is mounted or unmounted. As a
result the superblock doesn't have to be updated, either via the
journal or by setting s_dirt. There are a few exceptions, most
notably when resizing the file system, where the superblock needs to
be modified --- and in that case it should be done as a journalled
operation if possible, and s_dirt set only in no-journal mode.This patch will optimize out some unneeded disk writes when using ext4
with a journal.Signed-off-by: "Theodore Ts'o"
-
* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6:
wimax/i2400m: fix missing endian correction read in fw loader
net8139: fix a race at the end of NAPI
pktgen: Fix accuracy of inter-packet delay.
pkt_sched: gen_estimator: add a new lock
net: deliver skbs on inactive slaves to exact matches
ipv6: fix ICMP6_MIB_OUTERRORS
r8169: fix mdio_read and update mdio_write according to hw specs
gianfar: Revive the driver for eTSEC devices (disable timestamping)
caif: fix a couple range checks
phylib: Add support for the LXT973 phy.
net: Print num_rx_queues imbalance warning only when there are allocated queues
