10 Sep, 2010
1 commit
09 Sep, 2010
1 commit
-
If we pass in a device which is higher than SNDRV_RAWMIDI_DEVICES then
the "next device" should be -1. This function just returns device + 1.But the main thing is that "device + 1" can lead to a (harmless) integer
overflow and that annoys static analysis tools.[fix the case for device == SNDRV_RAWMIDI_DEVICE by tiwai]
Signed-off-by: Dan Carpenter
Signed-off-by: Takashi Iwai
08 Sep, 2010
8 commits
-
snd_hda_parse_pin_def_config() has some workaround for re-assigning
some pins declared as headphones to line-outs. This didn't work properly
for some cases because it used memmove() stupidly wrongly.Reference: Novell bnc#637263
https://bugzilla.novell.com/show_bug.cgi?id=637263Cc:
Signed-off-by: Takashi Iwai -
The error handling in snd_seq_oss_open() has several bad codes that
do dereferecing released pointers and double-free of kmalloc'ed data.
The object dp is release in free_devinfo() that is called via
private_free callback. The rest shouldn't touch this object any more.The patch changes delete_port() to call kfree() in any case, and gets
rid of unnecessary calls of destructors in snd_seq_oss_open().Fixes CVE-2010-3080.
Reported-and-tested-by: Tavis Ormandy
Cc:
Signed-off-by: Takashi Iwai -
The driver doesn't probe the device properly because of left-over cfg[]
that isn't used at all for msnd-classic device. This is only for msnd-
pinnacle.Signed-off-by: Takashi Iwai
-
EeePC 1001HAG has a similar problem like other ASUS machine, which doesn't
set the codec SSID properly for indicating the beep capability.
To enable PC-beep again, put this to the whitelist.Signed-off-by: Takashi Iwai
-
Add init verb sequence for errata ER880C3
http://www.cirrus.com/en/pubs/errata/ER880C3.pdfSigned-off-by: Brian Austin
Cc:
Signed-off-by: Takashi Iwai -
Due to the wrong "return" in the loop, a capture substream won't be
released at disconnection properly if the device is capture only and has
no playback substream. This caused Oops occasionally at the device
reconnection.Reported-by: Kim Minhyoung
Cc:
Signed-off-by: Takashi Iwai -
The Line and Mic inputs cannot be used at the same time, so the driver
has to automatically disable one of them if both are set. However, it
forgot to notify userspace about this change, so the mixer state would
be inconsistent. To fix this, check if the other control gets muted,
and send a notification event in this case.Signed-off-by: Clemens Ladisch
Reported-and-tested-by: Nathan Schagen
Cc:
Signed-off-by: Takashi Iwai -
For the WM8776 chip, this driver uses a different sample format and
more features than the Windows driver. When rebooting from Linux into
Windows, the latter driver does not reset the chip but assumes all its
registers have their default settings, so we get garbled sound or, if
the output happened to be muted before rebooting, no sound.To make that driver happy, hook our driver's cleanup function into the
shutdown notifier and ensure that the chip gets reset.Signed-off-by: Clemens Ladisch
Reported-and-tested-by: Nathan Schagen
Cc:
Signed-off-by: Takashi Iwai
07 Sep, 2010
1 commit
-
Lenovo T400s requires the quirk to make automatic HP/mic switching working.
Reported-by: Frank Becker
Cc:
Signed-off-by: Takashi Iwai
04 Sep, 2010
1 commit
-
The Audio Class v2 support code in 2.6.35 added checks for the
bInterfaceProtocol field. However, there are devices (usually those
detected by vendor-specific quirks) that do not have one of the
predefined values in this field, which made the driver reject them.To fix this regression, restore the old behaviour, i.e., assume that
a device with an unknown bInterfaceProtocol field (other than
UAC_VERSION_2) has more or less UAC-v1-compatible descriptors.[compile warning fixes by tiwai]
Signed-off-by: Clemens Ladisch
Cc: Daniel Mack
Cc:
Signed-off-by: Takashi Iwai
02 Sep, 2010
2 commits
-
For devices with more than one control interface, let's assume the first
one contains the audio controls. Unfortunately, there is no field in any
of the descriptors to tell us whether a control interface is for audio
or MIDI controls, so a better check is not easy to implement.On a composite device with audio and MIDI functions, for example, the
code currently overwrites chip->ctrl_intf, causing operations on the
control interface to fail if they are issued after the device probe.Signed-off-by: Daniel Mack
Signed-off-by: Takashi Iwai -
This new model adds the following functionality to HP G60:
- Automute of internal speakers
- Autoswitch of internal/external mics
- Remove SPDIF not physically presentBugLink: http://launchpad.net/bugs/587388
Cc: stable@kernel.org
Signed-off-by: David Henningsson
Signed-off-by: Takashi Iwai
29 Aug, 2010
2 commits
28 Aug, 2010
4 commits
-
There were some new formats added in commit 15c0cee6c809 "ALSA: pcm:
Define G723 3-bit and 5-bit formats". That commit increased
SNDRV_PCM_FORMAT_LAST as well. My concern is that there are a couple
places which do:for (i = 0; i < SNDRV_PCM_FORMAT_LAST; i++) {
if (dummy->pcm_hw.formats & (1ULL << i))
snd_iprintf(buffer, " %s", snd_pcm_format_name(i));
}I haven't tested these but it looks like if "i" were equal to
SNDRV_PCM_FORMAT_G723_24 or higher then we might read past the end of
the array.Signed-off-by: Dan Carpenter
Signed-off-by: Takashi Iwai -
The spinlock lock in sound_timer.c is used without initialization.
Signed-off-by: Akinobu Mita
Signed-off-by: Takashi Iwai -
If hw error is ignored, status is updated with invalid info.
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
I think this is a typo, debugfs_pop_time should not be executable.
Signed-off-by: Axel Lin
Acked-by: Liam Girdwood
Signed-off-by: Mark Brown
26 Aug, 2010
1 commit
-
The attached patch enables playback on a Sony VAIO machine.
BugLink: http://launchpad.net/bugs/618271
Signed-off-by: David Henningsson
Cc:
Signed-off-by: Takashi Iwai
23 Aug, 2010
4 commits
-
In synchronous mode the SSI_SRCCR values are ignored. Instead
SSI_STCCR must be used for both receiving and transmitting.Signed-off-by: Sascha Hauer
Acked-by: Liam Girdwood
Signed-off-by: Mark Brown -
This patch adds quirk for the Lenovo S10-3t so the headphone &
microphone jacks will now work.Signed-off-by: Jerone Young
Signed-off-by: Takashi Iwai
20 Aug, 2010
2 commits
-
The new sticky PCM parameter introduced the delayed clean-ups of
stream- and channel-id tags. In the current implementation, this check
(adding dirty flag) and actual clean-ups are done only for the codec
chip. However, with HD-audio architecture, multiple codecs can be
on a single bus, and the controller assign stream- and channel-ids in
the bus-wide.In this patch, the stream-id and channel-id are checked over all codecs
connected to the corresponding bus. Together with it, the mutex is
moved to struct hda_bus, as this becomes also bus-wide.Reported-and-tested-by: Stephen Warren
Signed-off-by: Takashi Iwai -
Intel and Nvidia HDMI codec drivers have own implementations of
sticky PCM parameters. Now HD-audio core part already has it,
thus both setups conflict. The fix is simply remove the part in
patch_intelhdmi.c and patch_nvhdmi.c and simply call
snd_hda_codec_setup_stream() as usual.Reported-and-tested-by: Stephen Warren
Signed-off-by: Takashi Iwai
19 Aug, 2010
3 commits
-
BugLink: https://bugs.launchpad.net/bugs/619439
This ThinkPad model needs External Amplifier muted for audible playback,
so set the inv_eapd quirk for it.Reported-and-tested-by: Dennis Bell
Cc:
Signed-off-by: Daniel T Chen
Signed-off-by: Takashi Iwai -
hdmi_eld_update_pcm_info() must be always compiled in.
Signed-off-by: Takashi Iwai
-
Just added new codec ids. These are almost compatible with existing ones.
Signed-off-by: Charles Chin
Signed-off-by: Takashi Iwai
18 Aug, 2010
3 commits
-
With some hardware combinations, the PCM interrupts are acknowledged
before the period boundary from the emu10k1 chip. The midlevel PCM code
gets confused and the playback stream is interrupted.It seems that the interrupt processing shift by 2 samples is enough
to fix this issue. This default value does not harm other,
non-affected hardware.More information: Kernel bugzilla bug#16300
[A copmile warning fixed by tiwai]
Signed-off-by: Jaroslav Kysela
Cc:
Signed-off-by: Takashi Iwai
17 Aug, 2010
1 commit
-
- Fix capture mixer elements for ALC680 base model
- Support auto change ADC for recording from MIC
- Cancel capture source assigned in auto mode.Signed-off-by: Kailang Yang
Signed-off-by: Takashi Iwai
16 Aug, 2010
4 commits
-
This is not supported by current hardware revisions.
Signed-off-by: Mark Brown
Acked-by: Liam Girdwood
Cc: stable@kernel.org -
model=dell-vostro is needed for Dell Vostro 1220 with Coexnat 5067.
Reference: Novell bnc#631066
https://bugzilla.novell.com/show_bug.cgi?id=631066Cc:
Signed-off-by: Takashi Iwai -
The detection and loading of firmeware on riptide driver has been broken
due to rewrite of some codes, checking the presense wrongly.
This patch fixes the logic again.Reference: kernel bug 16596
https://bugzilla.kernel.org/show_bug.cgi?id=16596Cc:
Signed-off-by: Takashi Iwai -
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6:
ALSA: sound/usb/format: silence uninitialized variable warnings
MAINTAINERS: Add Ian Lartey as comaintaner for Wolfson devices
MAINTAINERS: Make Wolfson entry also cover CODEC drivers
ASoC: Only tweak WM8994 chip configuration on devices up to rev D
ASoC: Optimise DSP performance for WM8994
ALSA: hda - Fix dynamic ADC change working again
ALSA: hda - Restrict PCM parameters per ELD information over HDMI
sound: oss: sh_dac_audio.c removed duplicated #include
15 Aug, 2010
2 commits