Doug / smarc-fsl-linux-kernel

17 Aug, 2009

4 commits

  • 12aac19d4   lockdep: Simplify lockdep_chains seqfile code ... Browse Code »

    - make lc_next() call lc_start()
    - use lock_chains directly instead of storing it in m->private

    Signed-off-by: Li Zefan
    Cc: Peter Zijlstra
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Li Zefan
     
  • 8109e1de8   lockdep: Simplify lockdep seqfile code ... Browse Code »

    Use seq_list_start_head() and seq_list_next().

    Signed-off-by: Li Zefan
    Cc: Peter Zijlstra
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Li Zefan
     
  • e9d65725b   lockdep: Fix missing entries in /proc/lock_chains ... Browse Code »

    Two entries are missing in the output of /proc/lock_chains.

    One is chains[1]. When lc_next() is called the 1st time,
    chains[0] is returned. And when it's called the 2nd time,
    chains[2] is returned.

    The other missing ons is, when lc_start() is called the 2nd
    time, we should start from chains[@pos-1] but not chains[@pos],
    because pos == 0 is the header.

    Signed-off-by: Li Zefan
    Cc: Peter Zijlstra
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Li Zefan
     
  • 212274347   lockdep: Fix missing entry in /proc/lock_stat ... Browse Code »

    One entry is missing in the output of /proc/lock_stat.

    The cause is, when ls_start() is called the 2nd time, we should
    start from stats[@pos-1] but not stats[@pos], because pos == 0
    is the header.

    Signed-off-by: Li Zefan
    Cc: Peter Zijlstra
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Li Zefan
     

02 Aug, 2009

7 commits

  • 90629209a   lockdep: Fix memory usage info of BFS ... Browse Code »

    The unit is KB, so sizeof(struct circular_queue) should be
    divided by 1024.

    Signed-off-by: Ming Lei
    Cc: akpm@linux-foundation.org
    Cc: torvalds@linux-foundation.org
    Cc: davem@davemloft.net
    Cc: Ming Lei
    Cc: a.p.zijlstra@chello.nl
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Ming Lei
     
  • e351b660f   lockdep: Reintroduce generation count to make BFS faster ... Browse Code »

    We still can apply DaveM's generation count optimization to
    BFS, based on the following idea:

    - before doing each BFS, increase the global generation id
    by 1

    - if one node in the graph has been visited, mark it as
    visited by storing the current global generation id into
    the node's dep_gen_id field

    - so we can decide if one node has been visited already, by
    comparing the node's dep_gen_id with the global generation id.

    By applying DaveM's generation count optimization to current
    implementation of BFS, we gain the following advantages:

    - we save MAX_LOCKDEP_ENTRIES/8 bytes memory;

    - we remove the bitmap_zero(bfs_accessed, MAX_LOCKDEP_ENTRIES);
    in each BFS, which is very time-consuming since
    MAX_LOCKDEP_ENTRIES may be very large.(16384UL)

    Signed-off-by: Ming Lei
    Signed-off-by: Peter Zijlstra
    Cc: "David S. Miller"
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Ming Lei
     
  • bb97a91e2   lockdep: Deal with many similar locks ... Browse Code »

    spin_lock_nest_lock() allows to take many instances of the same
    class, this can easily lead to overflow of MAX_LOCK_DEPTH.

    To avoid this overflow, we'll stop accounting instances but
    start reference counting the class in the held_lock structure.

    [ We could maintain a list of instances, if we'd move the hlock
    stuff into __lock_acquired(), but that would require
    significant modifications to the current code. ]

    We restrict this mode to spin_lock_nest_lock() only, because it
    degrades the lockdep quality due to lost of instance.

    For lockstat this means we don't track lock statistics for any
    but the first lock in the series.

    Currently nesting is limited to 11 bits because that was the
    spare space available in held_lock. This yields a 2048
    instances maximium.

    Signed-off-by: Peter Zijlstra
    Cc: Marcelo Tosatti
    Cc: Linus Torvalds
    Signed-off-by: Ingo Molnar

    Peter Zijlstra
     
  • f607c6685   lockdep: Introduce lockdep_assert_held() ... Browse Code »

    Add a lockdep helper to validate that we indeed are the owner
    of a lock.

    Signed-off-by: Peter Zijlstra
    Signed-off-by: Ingo Molnar

    Peter Zijlstra
     
  • 98c33edda   lockdep: Fix style nits ... Browse Code »

    fixes a few comments and whitespaces that annoyed me.

    Signed-off-by: Peter Zijlstra
    Signed-off-by: Ingo Molnar

    Peter Zijlstra
     
  • 4f84f4330   lockdep: Fix backtraces ... Browse Code »

    Truncate stupid -1 entries in backtraces.

    Signed-off-by: Peter Zijlstra
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Peter Zijlstra
     
  • bbfa26229   lockdep: Fix BFS build ... Browse Code »

    Fix:

    kernel/built-in.o: In function `lockdep_stats_show':
    lockdep_proc.c:(.text+0x48202): undefined reference to `max_bfs_queue_depth'

    As max_bfs_queue_depth is only available under
    CONFIG_PROVE_LOCKING=y.

    Cc: Ming Lei
    Cc: Peter Zijlstra
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Ingo Molnar
     

24 Jul, 2009

10 commits

  • af0129614   lockdep: BFS cleanup ... Browse Code »

    Some cleanups of the lockdep code after the BFS series:

    - Remove the last traces of the generation id
    - Fixup comment style
    - Move the bfs routines into lockdep.c
    - Cleanup the bfs routines

    [ tom.leiming@gmail.com: Fix crash ]
    Signed-off-by: Peter Zijlstra
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Peter Zijlstra
     
  • 12f3dfd02   lockdep: Add statistics info for max bfs queue depth ... Browse Code »

    Add BFS statistics to the existing lockdep stats.

    Signed-off-by: Ming Lei
    Signed-off-by: Peter Zijlstra
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Ming Lei
     
  • 4dd861d64   lockdep: Update memory usage introduced by BFS ... Browse Code »

    Also account the BFS memory usage.

    Signed-off-by: Ming Lei
    [ fix build for !PROVE_LOCKING ]
    Signed-off-by: Peter Zijlstra
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Ming Lei
     
  • ef681026f   lockdep: Implement lockdep_count_*ward_deps by BFS ... Browse Code »

    Implement lockdep_count_{for,back}ward using BFS.

    Signed-off-by: Ming Lei
    Signed-off-by: Peter Zijlstra
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Ming Lei
     
  • 24208ca76   lockdep: Introduce print_shortest_lock_dependencies ... Browse Code »

    Since the shortest lock dependencies' path may be obtained by BFS,
    we print the shortest one by print_shortest_lock_dependencies().

    Signed-off-by: Ming Lei
    Signed-off-by: Peter Zijlstra
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Ming Lei
     
  • d7aaba140   lockdep: Implement find_usage_*wards by BFS ... Browse Code »

    This patch uses BFS to implement find_usage_*wards(),which
    was originally writen by DFS.

    Signed-off-by: Ming Lei
    Signed-off-by: Peter Zijlstra
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Ming Lei
     
  • db0002a32   lockdep: Implement check_noncircular() by BFS ... Browse Code »

    This patch uses BFS to implement check_noncircular() and
    prints the generated shortest circle if exists.

    Signed-off-by: Ming Lei
    Signed-off-by: Peter Zijlstra
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Ming Lei
     
  • 9e2d551ea   lockdep: Introduce match function to BFS ... Browse Code »

    1,introduce match() to BFS in order to make it usable to
    match different pattern;

    2,also rename some functions to make them more suitable.

    Signed-off-by: Ming Lei
    Signed-off-by: Peter Zijlstra
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Ming Lei
     
  • d588e4615   lockdep: Improve implementation of BFS ... Browse Code »

    1,replace %MAX_CIRCULAR_QUE_SIZE with &(MAX_CIRCULAR_QUE_SIZE-1)
    since we define MAX_CIRCULAR_QUE_SIZE as power of 2;

    2,use bitmap to mark if a lock is accessed in BFS in order to
    clear it quickly, because we may search a graph many times.

    Signed-off-by: Ming Lei
    Signed-off-by: Peter Zijlstra
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Ming Lei
     
  • c94aa5ca3   lockdep: Print the shortest dependency chain if finding a circle ... Browse Code »

    Currently lockdep will print the 1st circle detected if it
    exists when acquiring a new (next) lock.

    This patch prints the shortest path from the next lock to be
    acquired to the previous held lock if a circle is found.

    The patch still uses the current method to check circle, and
    once the circle is found, breadth-first search algorithem is
    used to compute the shortest path from the next lock to the
    previous lock in the forward lock dependency graph.

    Printing the shortest path will shorten the dependency chain,
    and make troubleshooting for possible circular locking easier.

    Signed-off-by: Ming Lei
    Signed-off-by: Peter Zijlstra
    LKML-Reference:
    Signed-off-by: Ingo Molnar

    Ming Lei
     

23 Jul, 2009

19 commits