25 Dec, 2008

1 commit

  • Impact: build fix

    Some old architectures still do not use kernel/Kconfig.preempt, so the
    moving of the RCU options there broke their build:

    In file included from /home/mingo/tip/include/linux/sem.h:81,
    from /home/mingo/tip/include/linux/sched.h:69,
    from /home/mingo/tip/arch/alpha/kernel/asm-offsets.c:9:
    /home/mingo/tip/include/linux/rcupdate.h:62:2: error: #error "Unknown RCU implementation specified to kernel configuration"

    Move these options back to init/Kconfig, which every architecture
    includes.

    Signed-off-by: Ingo Molnar

    Ingo Molnar
     

19 Dec, 2008

2 commits

  • This patch fixes a long-standing performance bug in classic RCU that
    results in massive internal-to-RCU lock contention on systems with
    more than a few hundred CPUs. Although this patch creates a separate
    flavor of RCU for ease of review and patch maintenance, it is intended
    to replace classic RCU.

    This patch still handles stress better than does mainline, so I am still
    calling it ready for inclusion. This patch is against the -tip tree.
    Nevertheless, experience on an actual 1000+ CPU machine would still be
    most welcome.

    Most of the changes noted below were found while creating an rcutiny
    (which should permit ejecting the current rcuclassic) and while doing
    detailed line-by-line documentation.

    Updates from v9 (http://lkml.org/lkml/2008/12/2/334):

    o Fixes from remainder of line-by-line code walkthrough,
    including comment spelling, initialization, undesirable
    narrowing due to type conversion, removing redundant memory
    barriers, removing redundant local-variable initialization,
    and removing redundant local variables.

    I do not believe that any of these fixes address the CPU-hotplug
    issues that Andi Kleen was seeing, but please do give it a whirl
    in case the machine is smarter than I am.

    A writeup from the walkthrough may be found at the following
    URL, in case you are suffering from terminal insomnia or
    masochism:

    http://www.kernel.org/pub/linux/kernel/people/paulmck/tmp/rcutree-walkthrough.2008.12.16a.pdf

    o Made rcutree tracing use seq_file, as suggested some time
    ago by Lai Jiangshan.

    o Added a .csv variant of the rcudata debugfs trace file, to allow
    people having thousands of CPUs to drop the data into
    a spreadsheet. Tested with oocalc and gnumeric. Updated
    documentation to suit.

    Updates from v8 (http://lkml.org/lkml/2008/11/15/139):

    o Fix a theoretical race between grace-period initialization and
    force_quiescent_state() that could occur if more than three
    jiffies were required to carry out the grace-period
    initialization. Which it might, if you had enough CPUs.

    o Apply Ingo's printk-standardization patch.

    o Substitute local variables for repeated accesses to global
    variables.

    o Fix comment misspellings and redundant (but harmless) increments
    of ->n_rcu_pending (this latter after having explicitly added it).

    o Apply checkpatch fixes.

    Updates from v7 (http://lkml.org/lkml/2008/10/10/291):

    o Fixed a number of problems noted by Gautham Shenoy, including
    the cpu-stall-detection bug that he was having difficulty
    convincing me was real. ;-)

    o Changed cpu-stall detection to wait for ten seconds rather than
    three in order to reduce false positive, as suggested by Ingo
    Molnar.

    o Produced a design document (http://lwn.net/Articles/305782/).
    The act of writing this document uncovered a number of both
    theoretical and "here and now" bugs as noted below.

    o Fix dynticks_nesting accounting confusion, simplify WARN_ON()
    condition, fix kerneldoc comments, and add memory barriers
    in dynticks interface functions.

    o Add more data to tracing.

    o Remove unused "rcu_barrier" field from rcu_data structure.

    o Count calls to rcu_pending() from scheduling-clock interrupt
    to use as a surrogate timebase should jiffies stop counting.

    o Fix a theoretical race between force_quiescent_state() and
    grace-period initialization. Yes, initialization does have to
    go on for some jiffies for this race to occur, but given enough
    CPUs...

    Updates from v6 (http://lkml.org/lkml/2008/9/23/448):

    o Fix a number of checkpatch.pl complaints.

    o Apply review comments from Ingo Molnar and Lai Jiangshan
    on the stall-detection code.

    o Fix several bugs in !CONFIG_SMP builds.

    o Fix a misspelled config-parameter name so that RCU now announces
    at boot time if stall detection is configured.

    o Run tests on numerous combinations of configurations parameters,
    which after the fixes above, now build and run correctly.

    Updates from v5 (http://lkml.org/lkml/2008/9/15/92, bad subject line):

    o Fix a compiler error in the !CONFIG_FANOUT_EXACT case (blew a
    changeset some time ago, and finally got around to retesting
    this option).

    o Fix some tracing bugs in rcupreempt that caused incorrect
    totals to be printed.

    o I now test with a more brutal random-selection online/offline
    script (attached). Probably more brutal than it needs to be
    on the people reading it as well, but so it goes.

    o A number of optimizations and usability improvements:

    o Make rcu_pending() ignore the grace-period timeout when
    there is no grace period in progress.

    o Make force_quiescent_state() avoid going for a global
    lock in the case where there is no grace period in
    progress.

    o Rearrange struct fields to improve struct layout.

    o Make call_rcu() initiate a grace period if RCU was
    idle, rather than waiting for the next scheduling
    clock interrupt.

    o Invoke rcu_irq_enter() and rcu_irq_exit() only when
    idle, as suggested by Andi Kleen. I still don't
    completely trust this change, and might back it out.

    o Make CONFIG_RCU_TRACE be the single config variable
    manipulated for all forms of RCU, instead of the prior
    confusion.

    o Document tracing files and formats for both rcupreempt
    and rcutree.

    Updates from v4 for those missing v5 given its bad subject line:

    o Separated dynticks interface so that NMIs and irqs call separate
    functions, greatly simplifying it. In particular, this code
    no longer requires a proof of correctness. ;-)

    o Separated dynticks state out into its own per-CPU structure,
    avoiding the duplicated accounting.

    o The case where a dynticks-idle CPU runs an irq handler that
    invokes call_rcu() is now correctly handled, forcing that CPU
    out of dynticks-idle mode.

    o Review comments have been applied (thank you all!!!).
    For but one example, fixed the dynticks-ordering issue that
    Manfred pointed out, saving me much debugging. ;-)

    o Adjusted rcuclassic and rcupreempt to handle dynticks changes.

    Attached is an updated patch to Classic RCU that applies a hierarchy,
    greatly reducing the contention on the top-level lock for large machines.
    This passes 10-hour concurrent rcutorture and online-offline testing on
    128-CPU ppc64 without dynticks enabled, and exposes some timekeeping
    bugs in presence of dynticks (exciting working on a system where
    "sleep 1" hangs until interrupted...), which were fixed in the
    2.6.27 kernel. It is getting more reliable than mainline by some
    measures, so the next version will be against -tip for inclusion.
    See also Manfred Spraul's recent patches (or his earlier work from
    2004 at http://marc.info/?l=linux-kernel&m=108546384711797&w=2).
    We will converge onto a common patch in the fullness of time, but are
    currently exploring different regions of the design space. That said,
    I have already gratefully stolen quite a few of Manfred's ideas.

    This patch provides CONFIG_RCU_FANOUT, which controls the bushiness
    of the RCU hierarchy. Defaults to 32 on 32-bit machines and 64 on
    64-bit machines. If CONFIG_NR_CPUS is less than CONFIG_RCU_FANOUT,
    there is no hierarchy. By default, the RCU initialization code will
    adjust CONFIG_RCU_FANOUT to balance the hierarchy, so strongly NUMA
    architectures may choose to set CONFIG_RCU_FANOUT_EXACT to disable
    this balancing, allowing the hierarchy to be exactly aligned to the
    underlying hardware. Up to two levels of hierarchy are permitted
    (in addition to the root node), allowing up to 16,384 CPUs on 32-bit
    systems and up to 262,144 CPUs on 64-bit systems. I just know that I
    am going to regret saying this, but this seems more than sufficient
    for the foreseeable future. (Some architectures might wish to set
    CONFIG_RCU_FANOUT=4, which would limit such architectures to 64 CPUs.
    If this becomes a real problem, additional levels can be added, but I
    doubt that it will make a significant difference on real hardware.)

    In the common case, a given CPU will manipulate its private rcu_data
    structure and the rcu_node structure that it shares with its immediate
    neighbors. This can reduce both lock and memory contention by multiple
    orders of magnitude, which should eliminate the need for the strange
    manipulations that are reported to be required when running Linux on
    very large systems.

    Some shortcomings:

    o More bugs will probably surface as a result of an ongoing
    line-by-line code inspection.

    Patches will be provided as required.

    o There are probably hangs, rcutorture failures, &c. Seems
    quite stable on a 128-CPU machine, but that is kind of small
    compared to 4096 CPUs. However, seems to do better than
    mainline.

    Patches will be provided as required.

    o The memory footprint of this version is several KB larger
    than rcuclassic.

    A separate UP-only rcutiny patch will be provided, which will
    reduce the memory footprint significantly, even compared
    to the old rcuclassic. One such patch passes light testing,
    and has a memory footprint smaller even than rcuclassic.
    Initial reaction from various embedded guys was "it is not
    worth it", so am putting it aside.

    Credits:

    o Manfred Spraul for ideas, review comments, and bugs spotted,
    as well as some good friendly competition. ;-)

    o Josh Triplett, Ingo Molnar, Peter Zijlstra, Mathieu Desnoyers,
    Lai Jiangshan, Andi Kleen, Andy Whitcroft, and Andrew Morton
    for reviews and comments.

    o Thomas Gleixner for much-needed help with some timer issues
    (see patches below).

    o Jon M. Tollefson, Tim Pepper, Andrew Theurer, Jose R. Santos,
    Andy Whitcroft, Darrick Wong, Nishanth Aravamudan, Anton
    Blanchard, Dave Kleikamp, and Nathan Lynch for keeping machines
    alive despite my heavy abuse^Wtesting.

    Signed-off-by: Paul E. McKenney
    Signed-off-by: Ingo Molnar

    Paul E. McKenney
     
  • Ingo Molnar
     

18 Dec, 2008

26 commits

  • * 'i2c-fixes' of git://aeryn.fluff.org.uk/bjdooks/linux:
    i2c-s3c2410: fix check for being in suspend.
    i2c-cpm: Detect and report NAK right away instead of timing out

    Linus Torvalds
     
  • * 'upstream-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mfasheh/ocfs2:
    ocfs2: Add JBD2 compat feature bit.
    ocfs2: Always update xattr search when creating bucket.

    Linus Torvalds
     
  • * git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6:
    USB: pl2303: add id for Hewlett-Packard LD220-HP POS pole display
    USB: set correct configuration in probe of ti_usb_3410_5052
    USB: add 5372:2303 to pl2303
    USB: skip Set-Interface(0) if already in altsetting 0
    USB: fix comment about endianness of descriptors
    USB: Documentation/usb/gadget_serial.txt: update to match driver use_acm behaviour
    usbmon: drop bogus 0t from usbmon.txt
    USB: gadget: fix rndis working at high speed
    USB: ftdi_sio: Adding Ewert Energy System's CANdapter PID
    USB: tty: SprogII DCC controller identifiers
    usb-storage: update unusual_devs entry for Nokia 5310
    USB: Unusual devs patch for Nokia 3500c
    USB: storage: unusual_devs.h: Nokia 3109c addition
    USB: fix problem with usbtmc driver not loading properly

    Linus Torvalds
     
  • * git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core-2.6:
    STAGING: Move staging drivers back to staging-specific menu
    driver core: add newlines to debugging enabled/disabled messages
    xilinx_hwicap: remove improper wording in license statement
    driver core: fix using 'ret' variable in unregister_dynamic_debug_module

    Linus Torvalds
     
  • While testing a kernel with memory poisoning enabled, I saw some warnings
    about the redzone getting clobbered when chasing DFS referrals. The
    buffer allocation for the unicode converted version of the searchName is
    too small and needs to take null termination into account.

    Signed-off-by: Jeff Layton
    Acked-by: Steve French
    Signed-off-by: Linus Torvalds

    Jeff Layton
     
  • * 'merge' of git://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc:
    powerpc: Fix corruption error in rh_alloc_fixed()
    powerpc/fsl-booke: Fix the miss interrupt restore

    Linus Torvalds
     
  • Signed-off-by: Dmitry Baryshkov
    Signed-off-by: Greg Kroah-Hartman

    Dmitry Baryshkov
     
  • Both messages are missing the newline and thus dmesg output gets
    scrambled.

    Signed-off-by: Marcel Holtmann
    Signed-off-by: Greg Kroah-Hartman

    Marcel Holtmann
     
  • GPLv2 doesn't allow additional restrictions to be imposed on any
    code, so this wording needs to be removed from these files.

    Signed-off-by: Stephen Neuendorffer
    Cc: stable
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     
  • The 'ret' variable is assigned, but not used in the return statement. Fix this.

    Signed-off-by: Johann Felix Soden
    Acked-by: Jason Baron
    Signed-off-by: Greg Kroah-Hartman

    Johann Felix Soden
     
  • Add id for the Hewlett-Packard LD220-HP POS pole display.

    Bus 002 Device 002: ID 03f0:3524 Hewlett-Packard

    Signed-off-by: Mike Provencher
    Signed-off-by: Greg Kroah-Hartman

    Mike Provencher
     
  • This driver transfers firmware. It may just as well set the correct
    configuration.

    Signed-off-by: Oliver Neukum
    Signed-off-by: Greg Kroah-Hartman

    Oliver Neukum
     
  • This patch adds the "Superial" USB-Serial converter to pl2303 so that it
    is detected, by the correct driver. Adds the relevant vendor:product
    (5372:2303) to the device tables in pl2303.c & pl2303.h. The patch has
    been tested against 2.6.24-22-generic.

    Signed-off-by: Matthew D Arnold
    Signed-off-by: Greg Kroah-Hartman

    Matthew Arnold
     
  • When a driver unbinds from an interface, usbcore always sends a
    Set-Interface request to reinstall altsetting 0. Unforunately, quite
    a few devices have buggy firmware that crashes when it receives this
    request.

    To avoid such problems, this patch (as1180) arranges to send the
    Set-Interface request only when the interface is not already in
    altsetting 0.

    Signed-off-by: Alan Stern
    Signed-off-by: Greg Kroah-Hartman

    Alan Stern
     
  • This patch fixes a comment and clarifies the documentation about the
    endianness of descriptors. The current policy is that descriptors will
    be little-endian at the API even on big-endian systems; however the
    /proc/bus/usb API predates this policy and presents descriptors with
    some multibyte fields byte-swapped.

    Signed-off-by: Phil Endecott
    Signed-off-by: Alan Stern
    Signed-off-by: Greg Kroah-Hartman

    Phil Endecott
     
  • Commit 7bb5ea54 (usb gadget serial: use composite gadget framework)
    changed the default for the use_acm parameter from 0 to 1.
    Update the documentation to match.

    Signed-off-by: Peter Korsgaard
    Acked-by: David Brownell
    Signed-off-by: Greg Kroah-Hartman

    Peter Korsgaard
     
  • The example is incorrect: there is no 0t socket (the '1t' format has no
    bus number in it). Also, correct the broken sentence for USB Tag.

    Signed-off-by: Pete Zaitcev
    Signed-off-by: Greg Kroah-Hartman

    Pete Zaitcev
     
  • Fix a bug specific to highspeed mode in the recently updated RNDIS
    support: it wasn't setting up the high speed notification endpoint,
    which prevented high speed RNDIS links from working.

    Signed-off-by: David Brownell
    Tested-by: Anand Gadiyar
    Cc: stable
    Signed-off-by: Greg Kroah-Hartman

    David Brownell
     
  • The following patch adds in the USB PID for Ewert Energy System's CANdapter
    device (CANBUS to USB-Serial which uses the FTDI 245R chipset) to the ftdi_sio
    device driver.

    The patch was tested successfully on Linux kernel 2.6.27 under Ubuntu.

    Relevant output from /proc/bus/usb/devices (With patch installed):

    T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=12 MxCh= 0
    D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 8 #Cfgs= 1
    P: Vendor=0403 ProdID=9f80 Rev= 6.00
    S: Manufacturer=Ewert Energy Systems
    S: Product=CANdapter
    S: SerialNumber=A6RGB3Z3
    C:* #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr= 90mA
    I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=ftdi_sio
    E: Ad=81(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms
    E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms

    Signed-off-by: Andrew Ewert
    Signed-off-by: Greg Kroah-Hartman

    Andrew Ewert
     
  • Someone on rmweb reminded me this had been overlooked from ages ago..

    Add the identifiers for the Sprog II USB. This is a DCC control interface
    using the FTDI-SIO hardware: http://www.sprog-dcc.co.uk/. People have been
    using it with insmod options for ages, this just puts it into the driver
    data.

    Signed-off-by: Alan Cox
    Signed-off-by: Andrew Morton
    Signed-off-by: Greg Kroah-Hartman

    Alan Cox
     
  • This patch (as1179) updates the unusual_devs entry for Nokia's 5310
    phone to include a more recent firmware revision.

    This fixes Bugzilla #12099.

    Signed-off-by: Alan Stern
    Tested-by: Robson Roberto Souza Peixoto
    Cc: stable
    Signed-off-by: Greg Kroah-Hartman

    Alan Stern
     
  • T: Bus=02 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 3 Spd=12 MxCh= 0
    D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
    P: Vendor=0421 ProdID=0060 Rev= 5.51
    S: Manufacturer=Nokia
    S: Product=Nokia 3500c
    S: SerialNumber=357687010280751
    C:* #Ifs= 1 Cfg#= 1 Atr=c0 MxPwr=100mA
    I:* If#= 0 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-storage
    E: Ad=81(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms
    E: Ad=01(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms

    From: Ozan Sener
    Cc: stable
    Signed-off-by: Greg Kroah-Hartman

    Ozan Sener
     
  • 2.6.26(.x, cannot remember) could handle the microSD card in my Nokia
    3109c attached via USB as mass storage, 2.6.27(.x, up to and included
    2.6.27.8) cannot. Please find the attached patch which fixes this
    regression, and a copy of /proc/bus/usb/devices with my phone plugged in
    running with this patch on Frugalware.

    T: Bus=02 Lev=01 Prnt=01 Port=01 Cnt=02 Dev#= 4 Spd=12 MxCh= 0
    D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
    P: Vendor=0421 ProdID=0063 Rev= 6.01
    S: Manufacturer=Nokia
    S: Product=Nokia 3109c
    S: SerialNumber=359561013742570
    C:* #Ifs= 1 Cfg#= 1 Atr=c0 MxPwr=100mA
    I:* If#= 0 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-storage
    E: Ad=81(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms
    E: Ad=01(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms

    From: CSÉCSY László
    Cc: Phil Dibowitz
    Cc: stable
    Signed-off-by: Greg Kroah-Hartman

    CSÉCSY László
     
  • The usbtmc driver forgot to export its device table to userspace.
    Without this, it is never loaded properly when such a device is seen by
    the system.

    Cc: Marcel Janssen
    Cc: stable
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     
  • There is an error in rh_alloc_fixed() of the Remote Heap code:
    If there is at least one free block blk won't be NULL at the end of the
    search loop, so -ENOMEM won't be returned and the else branch of
    "if (bs == s || be == e)" will be taken, corrupting the management
    structures.

    Signed-off-by: Guillaume Knispel
    Acked-by: Timur Tabi
    Signed-off-by: Kumar Gala

    Guillaume Knispel
     
  • The commit e5e774d8833de1a0037be2384efccadf16935675
    powerpc/fsl-booke: Fix problem with _tlbil_va being interrupted
    introduce one issue. that casue the problem like this:

    Kernel BUG at c00b19fc [verbose debug info unavailable]
    Oops: Exception in kernel mode, sig: 5 [#1]
    MPC8572 DS
    Modules linked in:
    NIP: c00b19fc LR: c00b1c34 CTR: c0064e88
    REGS: ef02b7b0 TRAP: 0700 Not tainted (2.6.28-rc8-00057-g1bda712)
    MSR: 00021000 CR: 44048028 XER: 20000000
    TASK = ef02c000[1] 'init' THREAD: ef02a000
    GPR00: 00000001 ef02b860 ef02c000 eec201a0 c0dec2c0 00000000 000078a1 00000400
    GPR08: c00b4e40 000078a1 c048ec00 a1780000 44048028 ecd26917 00000001 ef02b948
    GPR16: ffffffea 0000020c 00000000 00000000 00000003 0000000a 00000000 000078a1
    GPR24: eec201a0 00000000 ed849000 00000400 ef02b95c 00000001 ef02b978 ef02b984
    NIP [c00b19fc] __find_get_block+0x24/0x238
    LR [c00b1c34] __getblk+0x24/0x2a0
    Call Trace:
    [ef02b860] [c017b768] generic_make_request+0x290/0x328 (unreliable)
    [ef02b8b0] [c00b1c34] __getblk+0x24/0x2a0
    [ef02b910] [c00b4ae4] __bread+0x14/0xf8
    [ef02b920] [c00fc228] ext2_get_branch+0xf0/0x138
    [ef02b940] [c00fcc88] ext2_get_block+0xb8/0x828
    [ef02ba00] [c00bbdc8] do_mpage_readpage+0x188/0x808
    [ef02bac0] [c00bc5b4] mpage_readpages+0xec/0x144
    [ef02bb50] [c00fba38] ext2_readpages+0x24/0x34
    [ef02bb60] [c006ade0] __do_page_cache_readahead+0x150/0x230
    [ef02bbb0] [c0064bdc] filemap_fault+0x31c/0x3e0
    [ef02bbf0] [c00728b8] __do_fault+0x60/0x5b0
    [ef02bc50] [c0011e0c] do_page_fault+0x2d8/0x4c4
    [ef02bd10] [c000ed90] handle_page_fault+0xc/0x80
    [ef02bdd0] [c00c7adc] set_brk+0x74/0x9c
    [ef02bdf0] [c00c9274] load_elf_binary+0x70c/0x1180
    [ef02be70] [c00945f0] search_binary_handler+0xa8/0x274
    [ef02bea0] [c0095818] do_execve+0x19c/0x1d4
    [ef02bed0] [c000766c] sys_execve+0x58/0x84
    [ef02bef0] [c000e950] ret_from_syscall+0x0/0x3c
    [ef02bfb0] [c009c6fc] sys_dup+0x24/0x6c
    [ef02bfc0] [c0001e04] init_post+0xb0/0xf0
    [ef02bfd0] [c046c1ac] kernel_init+0xcc/0xf4
    [ef02bff0] [c000e6d0] kernel_thread+0x4c/0x68
    Instruction dump:
    4bffffa4 813f000c 4bffffac 9421ffb0 7c0802a6 7d800026 90010054 bf210034
    91810030 7c0000a6 68008000 54008ffe 3d20c04e 3b29ffb8 38000008

    The issue was the beqlr returns early but we haven't reenabled interrupts.

    Signed-off-by: Dave Liu
    Signed-off-by: Kumar Gala

    Dave Liu
     

17 Dec, 2008

10 commits


16 Dec, 2008

1 commit

  • IDE hpt366 driver doesn't allow DMA for ATAPI devices and MWDMA2 on
    ATAPI device locks up pata_hpt366. Follow the suit.

    Signed-off-by: Tejun Heo
    Signed-off-by: Jeff Garzik

    Tejun Heo