18 Sep, 2012
1 commit
-
As discussed at the kernel summit this year, CONFIG_EXPERIMENTAL means
nothing, so let's get rid of it.Cc: Kees Cook
Cc: Arnd Bergmann
Cc: Tomas Winkler
Cc: Jiri Kosina
Cc: Paul Bolle
Cc: Andrew Morton
Cc: Anatolij Gustschin
Signed-off-by: Greg Kroah-Hartman
11 Sep, 2012
3 commits
-
non readable junk was printed to the logs
we will add proper buffer dumping mechanism later if neededSigned-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman
06 Sep, 2012
3 commits
-
Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
There was internal confusion in wether bus message
clinet (0) is counted in or notThe bitmap me_clients_map that accomodate
was initialized w/o it (255) but later on it
the clinet 0 was reservedThus were able to open only 252 instead of 253 clients
Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
1. rename mei_device variable to mei_pdev to remove
confusion with type 'struct mei_device'
2. mei_pdev no longer need to be gloabal so make it static
and remove the declaration from the header fileSigned-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman
17 Aug, 2012
10 commits
-
use watchdog_set/get_drvdata for passing mei_device
to watchdog_ops handlers instead of using global mei_deviceSigned-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
Before ME watchdog was exported through standard watchdog interface
it was closed and started together with the mei device.The major issue is that closing ME watchdog disabled also MEI device,
to fix this the watchdog state machine has to be independent from MEI
state machine.Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
1. rename defines to more be descriptive
2. remove duplicated defines from interface.h
3. add common prefix MEI_Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
According watchdog-kernel-api.txt WDIOF_SETTIMEOUT
should be set if the driver supplies set_timeout functionSigned-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
After watchdog was disabled the driver would stall
due to wrong calculation of credits reductionThe cat&paste bug was introduced in the commit
7bdf72d3d8059a50214069ea4b87c2174645f40f
mei: introduce mei_data2slots wrapperSigned-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
1. add MEI_DEV_ prefix for mei device state enums
2. rename mei_state to dev_state
3. add constant to string translation for debug purposesSigned-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
1. reformat PCI ids list in hw.h for better readability
2. update some code and brand namesSigned-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
The main purpose of this function is to exclude ME devices
without support for MEI/HECI interface from bindingCurrently affected systems are C600/X79 based servers
that expose PCI device even though it doesn't supported ME Interface.
MEI driver accessing such nonfunctional device can corrupt
the system.Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
me client search functions returns index
into me_client array according me client id
or me client uuid.1. Add common prefix for the functions mei_me_cl_<>
2. create new function mei_me_cl_by_id that wraps open
coded loops scattered over the code
3. rename mei_find_me_client_index to mei_me_cl_by_uuid
4. rename mei_find_me_client_update_filext to
mei_me_cl_update_filext and updates its parameter namesSigned-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman
20 Jul, 2012
1 commit
-
use module_pci_driver() macro to wrap standard
pci module registration into a single lineSigned-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman
18 Jul, 2012
1 commit
-
This lets us pick up the mei driver changes that we need in order to
handle future merge issues.Signed-off-by: Greg Kroah-Hartman
11 Jul, 2012
7 commits
-
1. straight up lines that doesn't cross 80 characters
2. don't break stringsSigned-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
change statements of types
if (ok)
do something
else
return errinto
if (err)
return errdo something
Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
Introduce mei_data2slots wrapper for sake of
readability. This wrapper close up the open code
for computing slots from a message length:
rond up dwords count from payload and header byte sizeSigned-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
when the default irq quick handler is used then IRQF_ONESHOT must be set
otherwise the request fails and following error is displayed:mei 0000:00:16.0: irq 48 for MSI/MSI-X
genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 48
mei 0000:00:16.0: request_threaded_irq failed: irq = 48.
dpm_run_callback(): pci_pm_resume+0x0/0x140 returns -22
PM: Device 0000:00:16.0 failed to resume async: error -22Reported-by: Peter Wu
Signed-off-by: Tomas Winkler
Tested-by: Peter Wu
Signed-off-by: Roland Dreier
Cc: stable # 3.5
Signed-off-by: Greg Kroah-Hartman
27 Jun, 2012
2 commits
-
1. Use unified _hbuf_ prefix for host/write buffer functions.
2. Cleanup the code w/o functional changes.Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
1. We record host (write) buffer depth during reset
so we don't need to query HCSR register later on.
The host buffer depth doesn't change after the reset
2. Use mei_hbuf_max_data function to compute payload size in bytesSigned-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman
21 Jun, 2012
4 commits
-
Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
check for overflow when retrieving empty write slots
Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
1. reduce hairy casting
2. replace open code with mei_count_empty_write_slots
4. include header size in check for overflow
3. use concise for loop instead of a while loopSigned-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
we cannot use if(!mei_flow_ctrl_creds()) logic as
mei_flow_ctrl_creds also negative error codesSigned-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman
14 Jun, 2012
5 commits
-
mei watchdog doesn't reboot the system it only produces event
therefore mark it as WDIOF_ALARMONLY.This patch depends on:
commit 2bbeed016dd96045ec82c3a309afddcc3a0db1d2
Author: Alan Cox
watchdog: Add a flag to indicate the watchdog doesn't reboot thingsSigned-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
Since MSI is enabled right before that, we should disable it when
registration fails.Signed-off-by: Samuel Ortiz
Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
This bug caused severe connectivity issue in the LMS application
(LMS is described in Documentation/misc-devices/mei/mei.txt)The bug was introduced in patch:
commit 1ccb7b6249f9bc50678e2a383084ed0a34cc9239
staging/mei: propagate error codes up in the write flowThe patch has reverted the return value logic of some fo function but
the conditional in _mei_irq_thread_read function was not swapped
making read always entering the error pathSigned-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
Since the misc device is registered only in the pci probe function
it has to be also unregistered in the counterpart pci remove function
and not in the module exit function.
In case of probe failure the driver was oopsing in module exit function.Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
when the default irq quick handler is used then IRQF_ONESHOT must be set
otherwise the request fails and following error is displayed:genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq ...
Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman
10 May, 2012
3 commits
-
1. move mei.txt, TODO, and the example code under Documentation/misc-devices/mei
2. update the TODO fileSigned-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
The header exports API for application layer
1. move under include/linux and add to the export list
2. update include path n the sources
3. update TODOSigned-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Tomas Winkler
Signed-off-by: Greg Kroah-Hartman