11 Jul, 2011
1 commit
-
There can 3 reasons for the "command reject" reply produced
by the stack. Each such reply should be accompanied by the
relevand data ( as defined in spec. ). Currently there is one
instance of "command reject" reply with reason "invalid cid"
wich is fixed. Also, added clean-up definitions related to the
"command reject" replies.Signed-off-by: Ilia Kolomisnky
Signed-off-by: Gustavo F. Padovan
08 Jul, 2011
2 commits
-
The ERTM receive buffer is now handled in a way that does not require
the busy queue and the associated polling code.Signed-off-by: Mat Martineau
Signed-off-by: Gustavo F. Padovan -
This change moves most L2CAP ERTM receive buffer handling out of the
L2CAP core and in to the socket code. It's up to the higher layer
(the socket code, in this case) to tell the core when its buffer is
full or has space available. The recv op should always accept
incoming ERTM data or else the connection will go down.Within the socket layer, an skb that does not fit in the socket
receive buffer will be temporarily stored. When the socket is read
from, that skb will be placed in the receive buffer if possible. Once
adequate buffer space becomes available, the L2CAP core is informed
and the ERTM local busy state is cleared.Receive buffer management for non-ERTM modes is unchanged.
Signed-off-by: Mat Martineau
Signed-off-by: Gustavo F. Padovan
17 Jun, 2011
2 commits
-
Instead of setting bits manually we use set_bit, test_bit, etc.
Also remove L2CAP_ prefix from macros.Signed-off-by: Gustavo F. Padovan
-
Instead of making the bit operations manually, we now use set_bit,
test_bit, etc.Signed-off-by: Gustavo F. Padovan
15 Jun, 2011
2 commits
-
This patch implements a check in smp cmd pairing request and pairing
response to verify if encryption key maximum size is compatible in both
slave and master when SMP Pairing is requested. Keys are also masked to
the correct negotiated size.Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Anderson Briglia
Signed-off-by: Gustavo F. Padovan -
This patch adds support for disconnecting the link when SMP procedure
takes more than 30 seconds.SMP begins when either the Pairing Request command is sent or the
Pairing Response is received, and it ends when the link is encrypted
(or terminated). Vol 3, Part H Section 3.4.Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Gustavo F. Padovan
14 Jun, 2011
9 commits
-
This patch includes support for generating and sending the random value
used to produce the confirmation value.Signed-off-by: Anderson Briglia
Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Gustavo F. Padovan -
This patch adds initial support for verifying the confirmation value
that the remote side has sent.Signed-off-by: Anderson Briglia
Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Gustavo F. Padovan -
ERTM use the generic L2CAP timer functions to keep a reference to the
channel. This is useful for avoiding crashes.Signed-off-by: Gustavo F. Padovan
-
We now plan to use l2cap_set_timer and l2cap_clear_timer in ERTM timers.
Signed-off-by: Gustavo F. Padovan
-
struct l2cap_chan has now its own refcnt that is compatible with the
socket refcnt, i.e., we won't see sk_refcnt = 0 and chan->refcnt > 0.Signed-off-by: Gustavo F. Padovan
-
Now socket state is tracked by struct sock and channel state is tracked by
chan->state. At this point both says the same, but this is going to change
when we add AMP Support for example.Signed-off-by: Gustavo F. Padovan
-
close() calls l2cap_sock_kill() on l2cap_sock.c
Signed-off-by: Gustavo F. Padovan
-
This abstracts the call to sock_queue_recv_skb() into
l2cap_chan_ops->recv().Signed-off-by: Gustavo F. Padovan
-
Add an abstraction layer between L2CAP core and its users (only
l2cap_sock.c now). The first function implemented is new_connection() that
replaces calls to l2cap_sock_alloc() in l2cap_core.cSigned-off-by: Gustavo F. Padovan
09 Jun, 2011
7 commits
-
Add BT_POWER socket option used to control the power
characteristics of the underlying ACL link. When the remote end
has put the link in sniff mode and the host stack wants to send
data we need need to explicitly exit sniff mode to work well with
certain devices (For example, A2DP on Plantronics Voyager 855).
However, this causes problems with HID devices.Hence, moving into active mode when sending data, irrespective
of who set the sniff mode has been made as a socket option. By
default, we will move into active mode. HID devices can set the
L2CAP socket option to prevent this from happening.Currently, this has been implemented for L2CAP sockets. This has been
tested with incoming and outgoing L2CAP sockets for HID and A2DP.Based on discussions on linux-bluetooth and patches submitted by
Andrei Emeltchenko.Signed-off-by: Jaikumar Ganesh
Signed-off-by: Gustavo F. Padovan -
To make it consistent with the rest of the API.
Signed-off-by: Gustavo F. Padovan
-
The call to l2cap_chan_clear_timer() is not really needed in l2cap_sock.c.
This patch also adds a call to l2cap_chan_clear_timer() to the only place
in __l2cap_sock_close() that wasn't calling it. It's safe call it there
because l2cap_chan_clear_timer() check first for timer_peding().Signed-off-by: Gustavo F. Padovan
-
The new timer does not belong to struct sock, tought it still touch some
sock things, but this will be sorted out soon.Signed-off-by: Gustavo F. Padovan
-
chan_type says if our chan is raw(direclty access to HCI),
connection less or connection oriented.Signed-off-by: Gustavo F. Padovan
-
This move all the sending logic to l2cap_core.c, but we still have a
socket dependence there, struct msghdr. It will be removed in some of the
further commits.Signed-off-by: Gustavo F. Padovan
-
This is actually __l2cap_sock_close() renamed to __l2cap_chan_close().
At a first look it may not make sense, but with the further cleanups that
will come it will.Signed-off-by: Gustavo F. Padovan
06 May, 2011
3 commits
-
A new list was added to replace the socket based one. This new list
doesn't depent on sock and then fits better inside l2cap_core.c code.It also rename l2cap_chan_alloc() to l2cap_chan_create() and
l2cap_chan_free() to l2cap_chan_destroy)Signed-off-by: Gustavo F. Padovan
-
When the user doesn't specify a psm we have the choose one for the
channel. Now we do this inside l2cap_add_psm().Signed-off-by: Gustavo F. Padovan
-
The intention is to get rid of the l2cap_sk_list usage inside
l2cap_core.c. l2cap_sk_list will soon be replaced by a list that does not
depend on socket usage.Signed-off-by: Gustavo F. Padovan
28 Apr, 2011
10 commits
-
l2cap_sk_ops can be static, it's not used outside l2cap_sock.c
Signed-off-by: Gustavo F. Padovan
-
A new l2cap_chan_free() is added to free the channels.
Signed-off-by: Gustavo F. Padovan
-
There is no need to the socket deal directly with the channel, most of the
time it cares about the channel only.Signed-off-by: Gustavo F. Padovan
-
In this commit, psm, scid and dcid.
Signed-off-by: Gustavo F. Padovan
-
In this commit, omtu, imtu, flush_to, mode and sport. It also remove the
pi var from l2cap_sock_sendmsg().Signed-off-by: Gustavo F. Padovan
-
In this commit all ERTM and Streaming Mode specific vars.
Signed-off-by: Gustavo F. Padovan
-
In this commit sec_level, force_reliable, role_switch and flushable.
Signed-off-by: Gustavo F. Padovan
-
l2cap_chan_connect() is a much better name and reflects what this
functions is doing (or will do once socket dependence is removed from the
core).Signed-off-by: Gustavo F. Padovan
-
First move of elements depending on user data.
Signed-off-by: Gustavo F. Padovan
-
If the allocation happens at l2cap_sock_create() will be able to use the
struct l2cap_chan to store channel info that comes from the user via
setsockopt.Signed-off-by: Gustavo F. Padovan
13 Apr, 2011
2 commits
-
tx_q is the queue used by ERTM mode.
Signed-off-by: Gustavo F. Padovan
-
As part of moving all the Channel related operation to struct l2cap_chan.
Signed-off-by: Gustavo F. Padovan
08 Apr, 2011
2 commits
-
As part of the moving channel stuff to l2cap_chan.
Signed-off-by: Gustavo F. Padovan
-
As part of the moving channel stuff to l2cap_chan.
Signed-off-by: Gustavo F. Padovan