26 Oct, 2005
1 commit
-
Signed-off-by: Jochen Friedrich
Signed-off-by: Arnaldo Carvalho de Melo
23 Oct, 2005
1 commit
-
On architectures where the char type defaults to unsigned some of the
arithmetic in the AX.25 stack to fail, resulting in some packets being dropped
on receive.Credits for tracking this down and the original patch to
Bob Brose N0QBJ .Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: Arnaldo Carvalho de Melo
11 Oct, 2005
1 commit
-
This is required to avoid unloading a module that has active timewait
sockets, such as DCCP.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller
09 Oct, 2005
1 commit
-
- added typedef unsigned int __nocast gfp_t;
- replaced __nocast uses for gfp flags with gfp_t - it gives exactly
the same warnings as far as sparse is concerned, doesn't change
generated code (from gcc point of view we replaced unsigned int with
typedef) and documents what's going on far better.Signed-off-by: Al Viro
Signed-off-by: Linus Torvalds
07 Oct, 2005
2 commits
-
Adds alignment attribute to a few structures used with SCTP socket
options so that the sizes and offsets remain the same when built using
either 32 or 64 bit tools.Signed-off-by: Sridhar Samudrala
Signed-off-by: David S. Miller -
The old socket options are marked with a _OLD suffix so that the
existing 32-bit apps on 32-bit kernels do not break.Signed-off-by: Ivan Skytte Jørgensen
Signed-off-by: Sridhar Samudrala
Signed-off-by: David S. Miller
06 Oct, 2005
1 commit
-
Here is a patch that adds a helper called xfrm_policy_id2dir to
document the fact that the policy direction can be and is derived
from the index.This is based on a patch by YOSHIFUJI Hideaki and 210313105@suda.edu.cn.
Signed-off-by: Herbert Xu
Signed-off-by: David S. Miller
05 Oct, 2005
4 commits
-
Fix implicit nocast warnings in xfrm code:
net/xfrm/xfrm_policy.c:232:47: warning: implicit cast to nocast typeSigned-off-by: Randy Dunlap
Signed-off-by: David S. Miller -
From: Randy Dunlap
Fix implicit nocast warnings in ip_vs code:
net/ipv4/ipvs/ip_vs_app.c:631:54: warning: implicit cast to nocast typeSigned-off-by: Randy Dunlap
Signed-off-by: David S. Miller -
Fix implicit nocast warnings in decnet code:
net/decnet/af_decnet.c:458:40: warning: implicit cast to nocast type
net/decnet/dn_nsp_out.c:125:35: warning: implicit cast to nocast type
net/decnet/dn_nsp_out.c:219:29: warning: implicit cast to nocast typeSigned-off-by: Randy Dunlap
Signed-off-by: David S. Miller -
No need to align struct inet_ehash_bucket on a 8 bytes boundary.
On 32 bits Uniprocessor, that's a waste of 4 bytes per struct (50 %)
On other platforms, the attribute is useless, natual alignement is already 8.
platform | Size before | Size after patch
-------------+-------------+------------------
32 bits, UP | 8 | 4
32 bits, SMP | 8 | 8
64 bits, UP | 8 | 8
64 bits, SMP | 16 | 16Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller
04 Oct, 2005
1 commit
-
Arnaldo and I agreed it could be applied now, because I have other
pending patches depending on this one (Thank you Arnaldo)(The other important patch moves skc_refcnt in a separate cache line,
so that the SMP/NUMA performance doesnt suffer from cache line ping pongs)1) First some performance data :
--------------------------------tcp_v4_rcv() wastes a *lot* of time in __inet_lookup_established()
The most time critical code is :
sk_for_each(sk, node, &head->chain) {
if (INET_MATCH(sk, acookie, saddr, daddr, ports, dif))
goto hit; /* You sunk my battleship! */
}The sk_for_each() does use prefetch() hints but only the begining of
"struct sock" is prefetched.As INET_MATCH first comparison uses inet_sk(__sk)->daddr, wich is far
away from the begining of "struct sock", it has to bring into CPU
cache cold cache line. Each iteration has to use at least 2 cache
lines.This can be problematic if some chains are very long.
2) The goal
-----------The idea I had is to change things so that INET_MATCH() may return
FALSE in 99% of cases only using the data already in the CPU cache,
using one cache line per iteration.3) Description of the patch
---------------------------Adds a new 'unsigned int skc_hash' field in 'struct sock_common',
filling a 32 bits hole on 64 bits platform.struct sock_common {
unsigned short skc_family;
volatile unsigned char skc_state;
unsigned char skc_reuse;
int skc_bound_dev_if;
struct hlist_node skc_node;
struct hlist_node skc_bind_node;
atomic_t skc_refcnt;
+ unsigned int skc_hash;
struct proto *skc_prot;
};Store in this 32 bits field the full hash, not masked by (ehash_size -
1) Using this full hash as the first comparison done in INET_MATCH
permits us immediatly skip the element without touching a second cache
line in case of a miss.Suppress the sk_hashent/tw_hashent fields since skc_hash (aliased to
sk_hash and tw_hash) already contains the slot number if we mask with
(ehash_size - 1)File include/net/inet_hashtables.h
64 bits platforms :
#define INET_MATCH(__sk, __hash, __cookie, __saddr, __daddr, __ports, __dif)\
(((__sk)->sk_hash == (__hash))
((*((__u64 *)&(inet_sk(__sk)->daddr)))== (__cookie)) && \
((*((__u32 *)&(inet_sk(__sk)->dport))) == (__ports)) && \
(!((__sk)->sk_bound_dev_if) || ((__sk)->sk_bound_dev_if == (__dif))))32bits platforms:
#define TCP_IPV4_MATCH(__sk, __hash, __cookie, __saddr, __daddr, __ports, __dif)\
(((__sk)->sk_hash == (__hash)) && \
(inet_sk(__sk)->daddr == (__saddr)) && \
(inet_sk(__sk)->rcv_saddr == (__daddr)) && \
(!((__sk)->sk_bound_dev_if) || ((__sk)->sk_bound_dev_if == (__dif))))- Adds a prefetch(head->chain.first) in
__inet_lookup_established()/__tcp_v4_check_established() and
__inet6_lookup_established()/__tcp_v6_check_established() and
__dccp_v4_check_established() to bring into cache the first element of the
list, before the {read|write}_lock(&head->lock);Signed-off-by: Eric Dumazet
Acked-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller
22 Sep, 2005
7 commits
-
In fact it is an exact copy of the parts that makes sense to LLC :-)
Signed-off-by: Arnaldo Carvalho de Melo
-
Borrowing the structure of TCP/IP for this. On the receive of new connections I
was bh_lock_socking the _new_ sock, not the listening one, duh, now it survives
the ssh connections storm I've been using to test this specific bug.Also fixes send side skb sock accounting.
Signed-off-by: Arnaldo Carvalho de Melo
-
Signed-off-by: Arnaldo Carvalho de Melo
-
Signed-off-by: Jochen Friedrich
Signed-off-by: Arnaldo Carvalho de Melo -
Signed-off-by: Jochen Friedrich
Signed-off-by: Arnaldo Carvalho de Melo -
Signed-off-by: Jochen Friedrich
Signed-off-by: Arnaldo Carvalho de Melo -
So as to set the newly created sk_buff ->dev member with it, that way we stop
using dev_base->next, that is the wrong thing to do, as there may well be
several interfaces being used with LLC. This was not such a big problem after
all as most of the users of llc_alloc_frame were setting the correct dev, but
this way code is reduced.This also fixes another bug in llc_station_ac_send_null_dsap_xid_c, that was
not setting the skb->dev field.Signed-off-by: Jochen Friedrich
Signed-off-by: Arnaldo Carvalho de Melo
15 Sep, 2005
1 commit
-
ip_vs_ftp when loaded can create NAT connections with unknown client
port for passive FTP. For such expectations we lookup with cport=0 on
incoming packet but it matches the format of the persistence templates
causing packets to other persistent virtual servers to be forwarded to
real server without creating connection. Later the reply packets are
treated as foreign and not SNAT-ed.This patch changes the connection lookup for packets from clients:
* introduce IP_VS_CONN_F_TEMPLATE connection flag to mark the
connection as template* create new connection lookup function just for templates -
ip_vs_ct_in_get* make sure ip_vs_conn_in_get hits only connections with
IP_VS_CONN_F_NO_CPORT flag set when s_port is 0. By this way
we avoid returning template when looking for cport=0 (ftp)Signed-off-by: Julian Anastasov
Signed-off-by: David S. Miller
14 Sep, 2005
1 commit
13 Sep, 2005
6 commits
-
This patch adds the handling of the extended inquiry responses and
inserts them into the inquiry cache.Signed-off-by: Marcel Holtmann
-
NET/ROM's virtual interfaces don't have a proper private data
structure yet. Create struct nr_private and put the statistics there.Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: David S. Miller -
NET/ROM is lacking a connection reset like TCP's RST flag which at times
may result in a connecting having to slowly timing out instead of just being
reset. An earlier attempt to reset the connection by sending a
NR_CONNACK | NR_CHOKE_FLAG transport was inacceptable as it did result in
crashes of BPQ systems. An alternative approach of introducing a new
transport type 7 (NR_RESET) has be implemented several years ago in
Paula Jayne Dowie G8PZT's Xrouter.Implement NR_RESET for Linux's NET/ROM but like any messing with the state
engine consider this experimental for now and thus control it by a sysctl
(net.netrom.reset) which for the time being defaults to off.Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: David S. Miller -
Comment the names used for the AX.25 state machine.
Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: David S. Miller -
Add a few more PID definitions. AX.25 PIDs are the equivalent to IP
protocol numbers.Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: David S. Miller -
Rename ax25_encapsulate to ax25_hard_header which these days more
accurately describes what the function is supposed to do.Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: David S. Miller
09 Sep, 2005
3 commits
-
Asc2ax was still using a static buffer for all invocations which isn't
exactly SMP-safe. Change asc2ax to take an additional result buffer as
the argument. Change all callers to provide such a buffer.This one only really is a fix for ROSE and as per recent discussions
there's still much more to fix in ROSE ...Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: David S. Miller -
Else we get build failures like:
CC arch/sparc64/kernel/sparc64_ksyms.o
In file included from arch/sparc64/kernel/sparc64_ksyms.c:28:
include/net/compat.h:37: warning: "struct sock" declared inside parameter list
include/net/compat.h:37: warning: its scope is only this definition or declaration, which is probably not what you wantSigned-off-by: David S. Miller
08 Sep, 2005
4 commits
-
When we copy 32bit ->msg_control contents to kernel, we walk the same
userland data twice without sanity checks on the second pass.Second version of this patch: the original broke with 64-bit arches
running 32-bit-compat-mode executables doing sendmsg() syscalls with
unaligned CMSG data areasAnother thing is that we use kmalloc() to allocate and sock_kfree_s()
to free afterwards; less serious, but also needs fixing.Signed-off-by: Al Viro
Signed-off-by: David Woodhouse
Signed-off-by: Chris Wright
Signed-off-by: Linus Torvalds -
Based on patch from David L Stevens
Signed-off-by: David L Stevens
Signed-off-by: YOSHIFUJI Hideaki -
Support several new socket options / ancillary data:
IPV6_RECVPKTINFO, IPV6_PKTINFO,
IPV6_RECVHOPOPTS, IPV6_HOPOPTS,
IPV6_RECVDSTOPTS, IPV6_DSTOPTS, IPV6_RTHDRDSTOPTS,
IPV6_RECVRTHDR, IPV6_RTHDR,
IPV6_RECVHOPOPTS, IPV6_HOPOPTSOld semantics are preserved as IPV6_2292xxxx so that
we can maintain backward compatibility.Signed-off-by: YOSHIFUJI Hideaki
07 Sep, 2005
2 commits
-
Hi Jeff,
This is version 19 of the Wireless Extensions. It was supposed
to be the fallback of the WPA API changes, but people seem quite happy
about it (especially Jouni), so the patch is rather small.
The patch has been fully tested with 2.6.13 and various
wireless drivers, and is in its final version. Would you mind pushing
that into Linus's kernel so that the driver and the apps can take
advantage ot it ?It includes :
o iwstat improvement (explicit dBm). This is the result of
long discussions with Dan Williams, the authors of
NetworkManager. Thanks to him for all the fruitful feedback.
o remove pointer from event stream. I was not totally sure if
this pointer was 32-64 bits clean, so I'd rather remove it and be at
peace with it.
o remove linux header from wireless.h. This has long been
requested by people writting user space apps, now it's done, and it
was not even painful.
o final deprecation of spy_offset. You did not like it, it's
now gone for good.
o Start deprecating dev->get_wireless_stats -> debloat netdev
o Add "check" version of event macros for ieee802.11
stack. Jiri Benc doesn't like the current macros, we aim to please ;-)
All those changes, except the last one, have been bit-roting on
my web pages for a while...Patches for most kernel drivers will follow. Patches for the
Orinoco and the HostAP drivers have been sent to their respective
maintainers.Have fun...
Jean
Signed-off-by: Jeff Garzik -
Ax2asc was still using a static buffer for all invocations which isn't
exactly SMP-safe. Change ax2asc to take an additional result buffer as
the argument. Change all callers to provide such a buffer.Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: David S. Miller
06 Sep, 2005
2 commits
-
The ipv4 and ipv6 protocols need to access it unconditionally.
SYSCTL=n build failure reported by Russell King.Signed-off-by: David S. Miller
-
Every file should #include the header files containing the prototypes
of it's global functions.In this case this showed that the prototype of irlan_print_filter()
was wrong which is also corrected in this patch.Signed-off-by: Adrian Bunk
Signed-off-by: David S. Miller
05 Sep, 2005
1 commit
02 Sep, 2005
1 commit
-
All we need to do is resegment the queue so that
we record SACK information accurately. The edges
of the SACK blocks guide our resegmenting decisions.With help from Herbert Xu.
Signed-off-by: David S. Miller